WordPress.org

Make WordPress Core

Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#30283 closed defect (bug) (fixed)

Set a minimum height on Appearance - Menus items.

Reported by: philiparthurmoore Owned by: SergeyBiryukov
Milestone: 4.1 Priority: normal
Severity: normal Version: 3.8
Component: Menus Keywords: has-patch
Focuses: administration Cc:

Description

When an empty title is used on a page its corresponding menu item in the Dashboard under Appearance - Menus is too short. See the attached image and patch.

Attachments (3)

30283.png (27.5 KB) - added by philiparthurmoore 6 years ago.
30283.diff (353 bytes) - added by philiparthurmoore 6 years ago.
30283-patched.png (42.9 KB) - added by philiparthurmoore 6 years ago.

Download all attachments as: .zip

Change History (9)

#1 follow-up: @philiparthurmoore
6 years ago

I wonder if __( '(no title)' ) would be appropriate here.

#2 in reply to: ↑ 1 @philiparthurmoore
6 years ago

Replying to philiparthurmoore:

I wonder if __( '(no title)' ) would be appropriate here.

Either way it may still make sense to have a minimum height on these items in case a plugin modifies the title output and we're left with nothing, as it's shown above.

#3 @kpdesign
6 years ago

  • Component changed from General to Menus
  • Focuses administration added
  • Keywords has-patch added

#4 @SergeyBiryukov
6 years ago

  • Milestone changed from Awaiting Review to 4.1

Reproduced in trunk by following the steps from #16787.

Previously fixed in [25211], broken again in [26072]. See also [24560] (didn't cover existing items).

#5 @SergeyBiryukov
6 years ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 30500:

Set min-height for menu item title. Add a fallback for empty-titled items.

props philiparthurmoore.
fixes #30283.

#6 @SergeyBiryukov
6 years ago

  • Version changed from trunk to 3.8
Note: See TracTickets for help on using tickets.