Make WordPress Core

Opened 10 years ago

Closed 10 years ago

#30554 closed defect (bug) (fixed)

<img> sizes attribute is stripped when switching from text to visual tab in the editor

Reported by: jhned's profile jhned Owned by:
Milestone: 4.2 Priority: normal
Severity: normal Version:
Component: TinyMCE Keywords: has-patch
Focuses: Cc:

Description

Going to the "text" tab to add sizes attribute (manually) to the image, and then going to "visual" tab results in that attribute being stripped out.

Related to issue #28993 "<img> srcset attribute is stripped when switching from text to visual tab in the editor (fixed)"

Attachments (1)

patch.diff (728 bytes) - added by gwelser 10 years ago.

Download all attachments as: .zip

Change History (11)

#1 @johnbillion
10 years ago

  • Keywords needs-patch added
  • Version trunk deleted

#2 @gwelser
10 years ago

Patch to add sizes to allowable img attributes.

@gwelser
10 years ago

#3 @gwelser
10 years ago

  • Keywords has-patch added; needs-patch removed

#4 @davideugenepratt
10 years ago

I applied the patch and it works for me.

#5 @SergeyBiryukov
10 years ago

patch.diff patches TinyMCE core, we can't do that :)

Like #28993, this should be fixed upstream first.

#7 @SergeyBiryukov
10 years ago

  • Milestone changed from Awaiting Review to 4.2

#8 in reply to: ↑ 6 @azaozz
10 years ago

Replying to gwelser:

Yep, it is fixed upstream and will be in WordPress 4.2. We will update TinyMCE in trunk when version 4.1.8 comes out.

#9 @DrewAPicture
10 years ago

When TinyMCE 4.1.8 is released and merged into core, we can call this fixed, see comment:8.

#10 @iseulde
10 years ago

  • Resolution set to fixed
  • Status changed from new to closed

Fixed in [31700], see #31551.

Note: See TracTickets for help on using tickets.