New function to network enable a theme

[igmoweb]

I haven't found any ticket asking about this but what if we create a new function to network enable/disable a theme?

Right now, wp-admin/themes.php is doing the following thing to enable themes in a network:

...
$allowed_themes = get_site_option( 'allowedthemes' );
	switch ( $action ) {
		case 'enable':
			check_admin_referer('enable-theme_' . $_GET['theme']);
			$allowed_themes[ $_GET['theme'] ] = true;
			update_site_option( 'allowedthemes', $allowed_themes );
...

We could encapsulate that in new functions, one to enabling and another to disabling.

Just in case, the code was pretty easy so I upload here a patch.

Thanks.

[igmoweb]

Enable/Disable themes network widly functions

[jeremyfelt]

Thanks for the ticket igmoweb, this seems pretty sensible.

• I'd go with the singular wp_network_enable_theme() and wp_network_disable_theme().
• We may be able to attach these as static methods to WP_Theme.

[igmoweb]

Patch updated

[igmoweb]

Patch updated (enable_themes_function_2.diff). Now using WP_Theme and also improved the comments.

Thanks.

[igmoweb]

Updated patch

[igmoweb]

Unit tests

[igmoweb]

I've updated the patch (enable_themes_function_3.diff), as it needed some refreshment and also attached two unit tests.

Thanks.

[igmoweb]

@jeremyfelt As discussed in #core, I'm attaching new patch: Functions + unit tests in the same patch

I've also added a few more asserts that make sure that network enabling/disabling the same theme twice works as expected.

[igmoweb]

New functions + Unit tests

[jeremyfelt]

Thanks @igmoweb, this is looking good.

Some minor adjustments:

• I think we can follow how WP_Theme is setup in general and use WP_Theme::network_enable_theme() and WP_Theme::network_disable_theme() directly without providing the wp_network_* wrapper functions.
• The additions to class-wp-theme.php need to be formatted per core code style. It looks like spacing is a bit off in the methods and the if statements need braces.
• Let's split the tests up into 4 parts: network enable a single theme, network enable an array of themes, network disable a single theme, and network disable an array of themes.

[igmoweb]

Hi @jeremyfelt

Here's the new patch.

Thanks.

[igmoweb]

Patch + Unit tests splited into 4 cases

[jorbin]

Due to lack of activity and the upcoming 4.5 beta 1 deadline, this is going to be punted.

[jeremyfelt]

Excellent stuff @igmoweb, thank you.

I've refreshed and adjusted the tests a bit in 30594.3.diff​ and added an is_multisite() check to each of the new methods. I think we'll be able to get this in early for 4.6.

[igmoweb]

Awesome. Thanks!

[jeremyfelt]

In 37202:

Multisite: Introduce WP_Theme methods to network enable/disable themes.

• WP_Theme::network_enable_theme() can be used to enable a theme or array of themes on a network.
• WP_Theme::network_disable_theme() can be used to disable a theme or array of themes on a network.
• Use these new methods in the network admin vs direct update_site_option() calls.
• Add tests.

Props igmoweb.
Fixes #30594.