WordPress.org
Get WordPress

Make WordPress Core

Opened 9 years ago

Closed 9 years ago

#30810 closed enhancement (wontfix)

Twenty Fifteen: Enqueue html5.js

Reported by: grapplerulrich's profile grapplerulrich Owned by:
Milestone: Priority: normal
Severity: normal Version: 4.2
Component: Bundled Theme Keywords:
Focuses: Cc:

Description

Twenty Fifteen should show a good example and enqueue the html5.js using the newly introduced filter in 4.1.

I have attached a patch.

Attachments (1)

twentyfifteen-html5.js.patch​ (1.9 KB) - added by grapplerulrich 9 years ago.

Download all attachments as: .zip

Change History (5)

@grapplerulrich
9 years ago

This ticket was mentioned in ​Slack in #core-themes by grapplerulrich. ​View the logs.
9 years ago

#2 @iamtakashi
9 years ago

Since #16024 has been progressed lately, it'd be better to wait for it that achieves in a cleaner way.

#3 @nacin
9 years ago

Agreed, I'd definitely prefer to see it hardcoded than added with script_loader_tag. If I knew this is how people would use script_loader_tag, I would have tried to land #16024 in the same release. :)

#4 @iandstewart
9 years ago

  • Milestone Awaiting Review deleted
  • Resolution set to wontfix
  • Status changed from new to closed

Closing this one out with Nacin's opinion script_loader_tag.

Note: See TracTickets for help on using tickets.