WordPress.org
Get WordPress

Make WordPress Core

Opened 12 years ago

Closed 11 years ago

#30890 closed defect (bug) (fixed)

Customizer: Widgets preview should use public api.preview instance

Reported by: ocean90 Owned by: westonruter
Priority: low Milestone: 4.5
Component: Customize Version: 3.9
Severity: normal Keywords: has-patch
Cc: Focuses: javascript

Description

See tags/4.1/src/wp-includes/js/customize-preview-widgets.js#L107​, #27666 and #30726.

Attachments (2)

30890.1.diff​ (1.1 KB ) - added by joshlevinson 11 years ago.
Binds to preview-ready event triggered by the preview instance vs the previous overriding of Preview.initialize.
30890.2.diff​ (1.0 KB ) - added by westonruter 11 years ago.
Fix highlighting of widgets in pane. Remove unused OldPreview. Fix jshint. Git change: ​https://github.com/xwp/wordpress-develop/commit/5b43c7078e7dee71ec281ed0924e1c95f1f28726

Download all attachments as: .zip

Change History (9)

This ticket was mentioned in ​Slack in #core-customize by celloexpressions. ​View the logs.
11 years ago

#2 @celloexpressions
11 years ago

  • Keywords good-first-bug removed
  • Owner set to westonruter
  • Priority normal → low
  • Status new → assigned

Too deep into internals for a good first bug, probably. Not urgent, but would be good to clean up at some point.

#3 @westonruter
11 years ago

  • Milestone Future Release → 4.5
  • Owner westonruter removed
  • Version → 3.9

@joshlevinson
11 years ago

Binds to preview-ready event triggered by the preview instance vs the previous overriding of Preview.initialize.

#4 @joshlevinson
11 years ago

  • Keywords has-patch added; needs-patch removed

This ticket was mentioned in ​Slack in #core-customize by joshlevinson. ​View the logs.
11 years ago

#6 @westonruter
11 years ago

  • Owner set to westonruter
  • Status assigned → reviewing

@westonruter
11 years ago

Fix highlighting of widgets in pane. Remove unused OldPreview. Fix jshint. Git change: ​https://github.com/xwp/wordpress-develop/commit/5b43c7078e7dee71ec281ed0924e1c95f1f28726

#7 @westonruter
11 years ago

  • Resolution → fixed
  • Status reviewing → closed

In 35783:

Customizer: Re-use public api.preview instance in widgets preview instead of unnecessarily capturing in api.Preview constructor wrapper.

The preview instance is no longer private.

Props joshlevinson, westonruter.
Fixes #30890.
See #30726.

Note: See TracTickets for help on using tickets.