WordPress.org

Make WordPress Core

Opened 5 years ago

Closed 4 years ago

#30890 closed defect (bug) (fixed)

Customizer: Widgets preview should use public api.preview instance

Reported by: ocean90 Owned by: westonruter
Milestone: 4.5 Priority: low
Severity: normal Version: 3.9
Component: Customize Keywords: has-patch
Focuses: javascript Cc:

Attachments (2)

30890.1.diff (1.1 KB) - added by joshlevinson 4 years ago.
Binds to preview-ready event triggered by the preview instance vs the previous overriding of Preview.initialize.
30890.2.diff (1.0 KB) - added by westonruter 4 years ago.
Fix highlighting of widgets in pane. Remove unused OldPreview. Fix jshint. Git change: https://github.com/xwp/wordpress-develop/commit/5b43c7078e7dee71ec281ed0924e1c95f1f28726

Download all attachments as: .zip

Change History (9)

This ticket was mentioned in Slack in #core-customize by celloexpressions. View the logs.


4 years ago

#2 @celloexpressions
4 years ago

  • Keywords good-first-bug removed
  • Owner set to westonruter
  • Priority changed from normal to low
  • Status changed from new to assigned

Too deep into internals for a good first bug, probably. Not urgent, but would be good to clean up at some point.

#3 @westonruter
4 years ago

  • Milestone changed from Future Release to 4.5
  • Owner westonruter deleted
  • Version set to 3.9

@joshlevinson
4 years ago

Binds to preview-ready event triggered by the preview instance vs the previous overriding of Preview.initialize.

#4 @joshlevinson
4 years ago

  • Keywords has-patch added; needs-patch removed

This ticket was mentioned in Slack in #core-customize by joshlevinson. View the logs.


4 years ago

#6 @westonruter
4 years ago

  • Owner set to westonruter
  • Status changed from assigned to reviewing

@westonruter
4 years ago

Fix highlighting of widgets in pane. Remove unused OldPreview. Fix jshint. Git change: https://github.com/xwp/wordpress-develop/commit/5b43c7078e7dee71ec281ed0924e1c95f1f28726

#7 @westonruter
4 years ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

In 35783:

Customizer: Re-use public api.preview instance in widgets preview instead of unnecessarily capturing in api.Preview constructor wrapper.

The preview instance is no longer private.

Props joshlevinson, westonruter.
Fixes #30890.
See #30726.

Note: See TracTickets for help on using tickets.