Make WordPress Core

Opened 9 years ago

Closed 9 years ago

Last modified 9 years ago

#30895 closed defect (bug) (fixed)

Fix recenty added .notice admin notice position on theme pages

Reported by: sippis's profile sippis Owned by: sergeybiryukov's profile SergeyBiryukov
Milestone: 4.1.1 Priority: normal
Severity: normal Version: 4.1
Component: Themes Keywords: fixed-major
Focuses: ui, administration Cc:

Description

New admin notices with class .notice overlaps with header on themes page.

In wp-admin/css/common.css after line 42, there should be line .themes-php div.notice, right now the style rules are targeting only to old notices (.error and .updated).

/* Position admin messages */
.themes-php div.updated,
.themes-php div.error {
	margin: 0 0 20px 0;
	clear: both;
}

Relevant ticket from the past; #26304

Attachments (1)

2015-01-04-wp-bug.png (8.0 KB) - added by sippis 9 years ago.

Download all attachments as: .zip

Change History (10)

#1 @SergeyBiryukov
9 years ago

  • Component changed from Administration to Themes
  • Milestone changed from Awaiting Review to 4.2

#2 @SergeyBiryukov
9 years ago

  • Focuses administration added

This ticket was mentioned in Slack in #core by sippis. View the logs.


9 years ago

#5 @SergeyBiryukov
9 years ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 31054:

Themes: Fix position of admin notice with .notice class.

fixes #30895.

#6 @SergeyBiryukov
9 years ago

  • Keywords fixed-major added
  • Milestone changed from 4.2 to 4.1.1
  • Resolution fixed deleted
  • Status changed from closed to reopened

Moving for 4.1.1 consideration.

#7 @jorbin
9 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 31080:

Themes: Fix position of admin notice with .notice class.

merges [31054] to the 4.1 branch

props SergeyBiryukov
fixes #30895.

This ticket was mentioned in Slack in #core by sippis. View the logs.


9 years ago

#9 @dd32
9 years ago

In 31435:

Revert [31080] from the 4.1 branch and replace it with a small function in an already changed file.
By doing this, we avoid shipping 400KB of changed CSS for such a minor css addition.

See https://build.trac.wordpress.org/changeset/31061 for the full size of [31080] in build.
See #30895.

Note: See TracTickets for help on using tickets.