#30997 closed defect (bug) (fixed)
Update grunt-cssjanus to fix RTL CSS Issues
Reported by: | netweb | Owned by: | ocean90 |
---|---|---|---|
Milestone: | 4.2 | Priority: | normal |
Severity: | normal | Version: | 4.0 |
Component: | Build/Test Tools | Keywords: | has-patch |
Focuses: | Cc: |
Description
Currently we are using a patched fork of CSSJanus via r29282 / #29038
The patched fork being used is https://github.com/cssjanus/cssjanus/pull/20
Updating to CSSJanus v1.1.1 fixes numerous issues in the following files:
wp-admin/css/common-rtl.css wp-admin/css/customize-controls-rtl.css wp-admin/css/customize-controls-rtl.min.css wp-admin/css/customize-widgets-rtl.css wp-admin/css/customize-widgets-rtl.min.css wp-admin/css/list-tables-rtl.css wp-admin/css/media-rtl.css wp-admin/css/themes-rtl.css wp-admin/css/wp-admin-rtl.min.css wp-includes/css/buttons-rtl.css wp-includes/css/buttons-rtl.min.css wp-includes/css/editor-rtl.css wp-includes/css/editor-rtl.min.css wp-includes/css/jquery-ui-dialog-rtl.css wp-includes/css/jquery-ui-dialog-rtl.min.css wp-includes/css/media-views-rtl.css wp-includes/css/media-views-rtl.min.css
@Oceans90, a couple of options, ideally the first option is preferred, if not the second:
- Update your pull request at https://github.com/cssjanus/cssjanus/pull/20 so it merges cleanly and we can natively revert to
grunt-cssjanus
once that pull request is merged and with hopefully a pending CSSJanus dependancy update from coming from @yoavf in https://github.com/yoavf/grunt-cssjanus/issues/4
- Update both your forks https://github.com/ocean90/grunt-cssjanus and https://github.com/ocean90/cssjanus to use CSSJanus v1.1.1 as the primary dependancy for
grunt-cssjanus
Attached for reference only even though the border-radius
bug is included are the extra changes to the RTL /build
files using CSSJanus v1.1.1.
Please and thank you in advance :)
Attachments (4)
Change History (15)
This ticket was mentioned in Slack in #core by netweb. View the logs.
10 years ago
#3
@
10 years ago
30997.patch includes CSSJanus v1.1.1 plus my updated pull request.
#4
follow-up:
↓ 6
@
10 years ago
Sweet, thanks Dominik, seeing as potentially the fix will be merged upstream this week let's hold of committing 30997.patch and see if we can revert to using the "standard" packages rather than forks.
#6
in reply to:
↑ 4
@
10 years ago
- Keywords needs-patch added; has-patch removed
Replying to netweb:
Sweet, thanks Dominik, seeing as potentially the fix will be merged upstream this week let's hold of committing 30997.patch and see if we can revert to using the "standard" packages rather than forks.
The above has now been merged upstream.
I've created a pull request to merge the above dependancy update in grunt-cssjanus
https://github.com/cssjanus/grunt-cssjanus/pull/9
Once the above is merged and we are explicitly using minimum CSS Janus v1.1.2 via Grunt-CSSJanus we can create a patch and commit.
#7
@
10 years ago
- Keywords has-patch added; needs-patch removed
@netweb Seems like we can update it now?
#8
@
10 years ago
- Keywords needs-patch added; has-patch removed
No, we cannot yet, the changes have been merged into the grunt-cssjanus
repo but the updated package has not been released to the NPM repo https://www.npmjs.com/package/grunt-cssjanus
Currently Grunt-CSSJanus is at v0.2.3 with CSSJanus 1.1.1 dependancy, we are awaiting Grunt-CSSJanus v0.2.4 with CSSJanus v1.1.2 dependancy.
#9
@
10 years ago
- Keywords has-patch added; needs-patch removed
grunt-cssjanus
v0.2.4 is now live at https://www.npmjs.com/package/grunt-cssjanus
Reference only: RTL /build files using CSSJanus v1.1.1.