WordPress.org

Make WordPress Core

Opened 3 years ago

Closed 3 years ago

Last modified 4 months ago

#29038 closed defect (bug) (fixed)

Code Typos in "customize-controls-rtl.css"

Reported by: DeBAAT Owned by: ocean90
Milestone: 4.0 Priority: normal
Severity: normal Version: 4.0
Component: Build/Test Tools Keywords: has-patch
Focuses: ui Cc:

Description

The file "\wp-admin\css\customize-controls-rtl.css" seems to have some typos on lines 403 and 404:

403	-webkit-border-radius: !important 0;
404	border-radius: !important 0;

should read:

	-webkit-border-radius: 0 !important;
	border-radius: 0 !important;

Attachments (2)

fixedtypo.diff (515 bytes) - added by voldemortensen 3 years ago.
fixed typos in css
29038.patch (542 bytes) - added by ocean90 3 years ago.
Temporarily switch to a pinned version of grunt-cssjanus. This in turn temporarily pins cssjanus to a patched fork, like we did before, see [26610].

Download all attachments as: .zip

Change History (12)

#1 @ocean90
3 years ago

  • Component changed from Formatting to Build/Test Tools
  • Keywords needs-patch added
  • Milestone changed from Awaiting Review to 4.0

Thanks, seems like an issue with CSSJanus.

@voldemortensen
3 years ago

fixed typos in css

#3 @ocean90
3 years ago

voldemortensen, RTL files are auto-generated on build process, so we can't apply your patch.

#4 @DrewAPicture
3 years ago

  • Keywords needs-patch removed

@ocean90: Heard anything upstream about whether this is gonna make it in time?

#5 @stephdau
3 years ago

  • Keywords has-patch added

@ocean90
3 years ago

Temporarily switch to a pinned version of grunt-cssjanus. This in turn temporarily pins cssjanus to a patched fork, like we did before, see [26610].

This ticket was mentioned in IRC in #wordpress-dev by ocean90. View the logs.


3 years ago

#7 @ocean90
3 years ago

  • Owner set to ocean90
  • Resolution set to fixed
  • Status changed from new to closed

In 29505:

Temporarily switch to a pinned version of grunt-cssjanus. This in turn temporarily pins cssjanus to a patched fork.

fixes #29038.

#9 @ocean90
4 months ago

In 39747:

Build: Update pinned version of grunt-cssjanus for the 4.1 branch to hopefully please the build.

See #29038.

#10 @ocean90
4 months ago

In 39748:

Build: Update pinned version of grunt-cssjanus for the 4.0 branch to hopefully please the build.

See #29038.

Note: See TracTickets for help on using tickets.