WordPress.org

Make WordPress Core

Opened 5 years ago

Last modified 5 months ago

#31077 new enhancement

oEmbed errors should be shown in the media manager to match TinyMCE

Reported by: johnbillion Owned by:
Milestone: Priority: normal
Severity: normal Version:
Component: Media Keywords: needs-patch
Focuses: administration Cc:
PR Number:

Description

If you attempt to insert an oEmbed-supported embed on an HTTPS site but the provider doesn't support HTTPS, then an error is shown in the editor:

https://i.imgur.com/vgSIMaz.png

This error is not shown in the media manager if you attempt to do the same.

Attachments (1)

31077.patch (2.0 KB) - added by johnbillion 5 years ago.

Download all attachments as: .zip

Change History (3)

@johnbillion
5 years ago

#1 @johnbillion
5 years ago

  • Keywords has-patch added

31077.patch implements the above. It copies some CSS from wp-content.css to common.css, which may or may not be appropriate, but I don't think we want to remove this CSS from wp-content.css for back-compat reasons.

#2 @wonderboymusic
5 years ago

  • Keywords needs-patch added; has-patch removed
  • Milestone changed from Awaiting Review to Future Release

Needs to edit the modules instead of media-views.js. If the UI/UX makes sense, could be bumped to 4.2

Note: See TracTickets for help on using tickets.