![(please configure the [header_logo] section in trac.ini)](/chrome/site/your_project_logo.png){kind=logo}
Opened 12 years ago
Last modified 2 months ago
#31076 new defect (bug)
Multisite signup functions don't support SSL
| Reported by: | SergeyBiryukov | Owned by: | |
|---|---|---|---|
| Priority: | normal | Milestone: | |
| Component: | Login and Registration | Version: | |
| Severity: | normal | Keywords: | https has-patch has-unit-tests |
| Cc: | Focuses: | multisite |
Description
confirm_blog_signup(), confirm_another_blog_signup(), and wpmu_signup_blog_notification() use hardcoded http:// links.
Attachments (2)
Change History (12)
#4
@
10 years ago
In [34790], a $blog_id parameter has been introduced in confirm_another_blog_signup(). If it is set, then the function uses home_url() and wp_login_url() to generate the necessary URLs.
We could do the same thing in wpmu_signup_blog_notification() and confirm_blog_signup().
This ticket was mentioned in Slack in #core-http by johnbillion. View the logs.
10 years ago
This ticket was mentioned in PR #12328 on WordPress/wordpress-develop by @sukhendu2002.
4 months ago
#8
- Keywords has-patch has-unit-tests added; needs-patch removed
Trac ticket: https://core.trac.wordpress.org/ticket/31076
This ticket was mentioned in Slack in #core by cbravobernal. View the logs.
3 months ago
#10
@
2 months ago
Opened PR for this ticket: https://github.com/WordPress/wordpress-develop/pull/12328
The PR removes the remaining hardcoded http:// signup URLs, keeps subdomain installs conservative by default, and adds unit test coverage.
Feedback appreciated, thank you!
We probably need to check a little further before assuming SSL in some cases. If a new subdomain or domain is being created, it's not necessarily the case that SSL will be available for activation. For subdirectories, we should have no trouble assuming the same scheme as the network.