WordPress.org

Make WordPress Core

Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#31208 closed defect (bug) (fixed)

jQuery UI: Add missing jquery-ui-core dependency for progressbar

Reported by: tyxla Owned by: ocean90
Milestone: 4.2 Priority: normal
Severity: normal Version: 3.3
Component: Script Loader Keywords: has-patch
Focuses: Cc:
PR Number:

Description

jQuery UI progressbar needs both jquery-ui-core and jquery-ui-widget, but jquery-ui-core is missed. This dependency can be seen in the jQuery UI download builder: http://jqueryui.com/download/#!version=1.11.2&components=1100000000000001000000000000000000000

The jQuery UI progressbar appears to be missing this dependency since it was introduced in WordPress 3.3.

Attachments (1)

31208.patch (1.3 KB) - added by tyxla 5 years ago.
Add jquery-ui-core as dependency for jquery-ui-progressbar in the script loader

Download all attachments as: .zip

Change History (8)

#1 @tyxla
5 years ago

  • Keywords needs-patch added

@tyxla
5 years ago

Add jquery-ui-core as dependency for jquery-ui-progressbar in the script loader

#2 @tyxla
5 years ago

  • Keywords has-patch added; needs-patch removed

#3 @ocean90
5 years ago

  • Owner set to ocean90
  • Resolution set to fixed
  • Status changed from new to closed

In 31322:

jQuery UI: Add jquery-ui-core as dependency for jquery-ui-progressbar.

props tyxla.
fixes #31208.

#4 @ocean90
5 years ago

  • Milestone changed from Awaiting Review to 4.2

#5 follow-up: @tyxla
5 years ago

I believe this should be changed to milestone 4.1.1, just like #31113? These 2 tickets are quite similar IMHO. That's where I drew inspiration from actually.

Last edited 5 years ago by tyxla (previous) (diff)

#6 in reply to: ↑ 5 @ocean90
5 years ago

Replying to tyxla:

I believe this should be changed to milestone 4.1.1, just like #31113? These 2 tickets are quite similar IMHO. That's where I drew inspiration from actually.

It's similar yes, but this one is not a regression in 4.1.

#7 @tyxla
5 years ago

@ocean90: Oh, that makes sense. Thanks for clarifying that for me.

Note: See TracTickets for help on using tickets.