grid view in media library malfunctioning in Simplified Chinese install

[kidsguide]

Media library grid breaks in Simplified Chinese install.
​https://wordpress.org/support/topic/the-grid-view-of-media-gallery-is-malfunctioning-in-simplified-chinese-install?replies=1

[SergeyBiryukov]

Could not reproduce on a clean install: 31252.png​. Which browser and OS is the reporter using?

This should probably remain on support forums until the bug is identified and confirmed.

[SergeyBiryukov]

OK, I can reproduce now. Investigating.

My steps:

1. Switched to zh_CN locale from General Settings.
2. For some reason, it displayed a 4.1 update nag, although I already was on 4.1.
3. After I reinstalled it via the Updates screen, I could reproduce the issue.

[afercia]

in English
media-views-css is loaded before wp-admin-css
in Chinese
wp-admin-css is loaded before media-views-css

no idea why at the moment :)
thanks to the CSS cascade:

in English:
.wp-filter
position: relative;
wins on
.media-toolbar
position: absolute;

in Chinese: vice-versa

[SergeyBiryukov]

Replying to afercia:

in English
media-views-css is loaded before wp-admin-css
in Chinese
wp-admin-css is loaded before media-views-css

Caused by ​bundled stylesheets in the zh_CN build.

Those styles were merged into core in [19825] and should be removed from the package.

[samuelsidler]

I don't think there's any way this should be a blocker for 4.2, given that it's in a separate package. There's nothing specific we can do in core right now.

@dallaslu, @franklsf, @jimmyxu, @xslidian, @dreamcolor, @jiehanzheng, @musiclog: As cn validators, can you ensure that the Chinese styles are removed from the package going forward? Note that we merged them into core in [19825].

[SergeyBiryukov]

Replying to samuelsidler:

There's nothing specific we can do in core right now.

We could make the affected CSS rules a bit more specific (e.g. prepended with .wp-core-ui), so that the order of files doesn't matter. That should make it more future-proof. But yeah, removing obsolete files from the zh_CN build is a simple fix for now.

[jimmyxu]

Replying to samuelsidler:

As cn validators, can you ensure that the Chinese styles are removed from the package going forward? Note that we merged them into core in [19825].

Will do when I prepare for 4.2 :)

[samuelsidler]

Moving off of 4.2. We can do @SergeyBiryukov's recommendation in comment 7, but it won't block 4.2, given that the zh_CN team will fix this in their build.

[chriscct7]

@kidsguide 'needs refresh' is used when there's a patch applied to a ticket that no longer can be cleanly applied to the SVN repository of WordPress core.

In this case, there's no patch, so 'needs patch' is what needs to be done