WordPress.org

Make WordPress Core

Opened 5 years ago

Closed 5 years ago

#31408 closed defect (bug) (fixed)

Alignment of labels and checkboxes is off on quick edit

Reported by: mattheu Owned by: ocean90
Milestone: 4.2 Priority: normal
Severity: normal Version: 4.2
Component: Quick/Bulk Edit Keywords: has-patch commit
Focuses: ui Cc:

Description

Its a pretty small issue - but the alignment of labels on the quick edit screen is a bit wonky.

https://dl.dropboxusercontent.com/s/9ma4qhh0t8c3uxv/2015-02-21%20at%2021.58%202x.png

I have a patch to fix this. Heres what it looks like after the patch.

https://dl.dropboxusercontent.com/s/abpt0ld9euqv5pz/2015-02-21%20at%2022.07%202x.png

I've tested this on Chrome/Firefox and IE11 (and 8 up using emulator)

This has been an issue for a while - since the admin redesign.

Attachments (3)

31408.diff (2.4 KB) - added by mattheu 5 years ago.
31408.2.diff (2.4 KB) - added by mattheu 5 years ago.
31408.3.diff (2.6 KB) - added by valendesigns 5 years ago.

Download all attachments as: .zip

Change History (11)

@mattheu
5 years ago

#1 in reply to: ↑ description @DrewAPicture
5 years ago

  • Component changed from General to Quick/Bulk Edit
  • Keywords has-patch added
  • Milestone changed from Awaiting Review to 4.2

Replying to mattheu:

I've tested this on Chrome/Firefox and IE11 (and 8 up using emulator)

This has been an issue for a while - since the admin redesign.

Thanks. Worth also taking a look at Safari/Opera and mobile browsers.

#2 @mattheu
5 years ago

Updating the patch with a small fix for opera.

Tested again including safari/opera and the iOS simulator. All looks good. Unfortunately I don't have access to other devices.

Mobile isn't great here anyway but, and this change doesn't make it any better or worse.

@mattheu
5 years ago

This ticket was mentioned in Slack in #core by drew. View the logs.


5 years ago

#4 @DrewAPicture
5 years ago

  • Keywords commit added

31408.2.diff still applies and definitely improves the alignment for me. Tested in latest Firefox, Chrome, and Safari. IE 8, 9, 10, and 11. Moving for commit consideration.

#5 @valendesigns
5 years ago

  • Keywords needs-refresh added; has-patch commit removed

It was discussed in Slack that this patch needs a refresh with unitless line heights. Which I will work on later tonight unless anyone wants to work on it before then, just give me a heads up so we don't duplicate our efforts.

@valendesigns
5 years ago

#6 @valendesigns
5 years ago

  • Keywords has-patch commit added; needs-refresh removed

Patch 31408.3.diff adds unitless line heights and mobile styles for .inline-edit-or.

#7 @ocean90
5 years ago

  • Owner set to ocean90
  • Status changed from new to reviewing

#8 @ocean90
5 years ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

In 31890:

Improve alignment of labels and inputs in Quick Edit.

props mattheu, valendesigns.
fixes #31408.

Note: See TracTickets for help on using tickets.