WordPress.org

Make WordPress Core

Opened 5 years ago

Closed 5 years ago

#31455 closed defect (bug) (fixed)

Press This: Fix scrolling in FF

Reported by: Michael Arestad Owned by: azaozz
Milestone: 4.2 Priority: normal
Severity: normal Version: 4.2
Component: Press This Keywords:
Focuses: Cc:

Description

Currently, Firefox doesn't allow for scrolling at all unless there is height: 100% on body when combined with overflow-x: hidden;. (I discovered after tons of trial and error.) On iOS Safari, height 100% on html prevents scrolling. This patch should fix the FF issue without breaking scrolling on iOS Safari.

Attachments (1)

31455.patch (493 bytes) - added by Michael Arestad 5 years ago.

Download all attachments as: .zip

Change History (4)

#1 @SergeyBiryukov
5 years ago

  • Milestone changed from Awaiting Review to 4.2

#2 @azaozz
5 years ago

This doesn't seem to fix it. Seems Firefox follows the standards to the point and needs scrollbars specified in window.open(): https://developer.mozilla.org/en-US/docs/Web/API/Window/open.

Will keep the css changes too. As far as I remember setting html and body to overflow-x:hidden may disable both scrollbars.

#3 @azaozz
5 years ago

  • Owner set to azaozz
  • Resolution set to fixed
  • Status changed from new to closed

In 31565:

PressThis: enable scrollbars in Firefox, remove overflow-x: hidden from the html element. Part props Michael-Arestad. Fixes #31455.

Note: See TracTickets for help on using tickets.