WordPress.org
Get WordPress

Make WordPress Core

Opened 10 years ago

Closed 10 years ago

#31541 closed task (blessed) (fixed)

Upgrade to MediaElement 2.16.4

Reported by: wonderboymusic's profile wonderboymusic Owned by:
Milestone: 4.2 Priority: normal
Severity: normal Version: 4.2
Component: External Libraries Keywords:
Focuses: Cc:

Description

We need to keep up to date. Includes some pull requests from us.

​https://github.com/johndyer/mediaelement/compare/2.16.2...2.16.4

Attachments (2)

4.2.monkey.diff​ (19.0 KB) - added by wonderboymusic 10 years ago.
4.2.monkey.2.diff​ (19.0 KB) - added by wonderboymusic 10 years ago.

Download all attachments as: .zip

Change History (7)

@wonderboymusic
10 years ago

#1 @wonderboymusic
10 years ago

To document how one monkey-patches MEjs:

  • Checkout the MediaElement GitHub repo: ​https://github.com/johndyer/mediaelement
  • patch -p0 < 4.2.monkey.diff (attached above)
  • from repo root, simply run grunt noflash
  • get the built files you need from local-build/

Building Flash is weird and annoying and is almost never necessary for these fidgets we do.

#3 @dd32
10 years ago

@wonderboymusic can you squeeze ​PR1423 into the monkeypatching too?
It's what's needed for fixing #31058 for 4.2+ (or we can just apply [31444] to trunk as well and be done with it)

#4 @wonderboymusic
10 years ago

@dd32: on it

@wonderboymusic
10 years ago

#5 @wonderboymusic
10 years ago

  • Resolution set to fixed
  • Status changed from new to closed

[31643]

Note: See TracTickets for help on using tickets.