Make WordPress Core

Context Navigation

← Previous Ticket
Next Ticket →

Opened 11 years ago

Closed 11 years ago

#31541 closed task (blessed) (fixed)

Upgrade to MediaElement 2.16.4

Reported by:	wonderboymusic	Owned by:
Priority:	normal	Milestone:	4.2
Component:	External Libraries	Version:	4.2
Severity:	normal	Keywords:
Cc:		Focuses:

Description

We need to keep up to date. Includes some pull requests from us.

https://github.com/johndyer/mediaelement/compare/2.16.2...2.16.4

Attachments (2)

4.2.monkey.diff (19.0 KB ) - added by wonderboymusic 11 years ago.
4.2.monkey.2.diff (19.0 KB ) - added by wonderboymusic 11 years ago.

Download all attachments as: .zip

Change History (7)

@wonderboymusic
11 years ago

Attachment 4.2.monkey.diff added

#1 @wonderboymusic
11 years ago

To document how one monkey-patches MEjs:

Checkout the MediaElement GitHub repo: https://github.com/johndyer/mediaelement
patch -p0 < 4.2.monkey.diff (attached above)
from repo root, simply run grunt noflash
get the built files you need from local-build/

Building Flash is weird and annoying and is almost never necessary for these fidgets we do.

#2 @wonderboymusic
11 years ago

Ugrade to MediaElement 2.16.4:
https://github.com/johndyer/mediaelement/compare/2.16.2...2.16.4

Includes PRs from WordPress folk:
https://github.com/johndyer/mediaelement/commit/1a74854abf94bef8e779edcf564b5e89869f2672
https://github.com/johndyer/mediaelement/commit/f438256f5c3144258ba9f2f16de9dbca8b735d47
https://github.com/johndyer/mediaelement/commit/8b9856accd4236390492ad2f08c597558a82504a

Monkey-patch MediaElement to restore H264 support to Chromium.

Documented here:
https://core.trac.wordpress.org/ticket/31541#comment:1

#3 @dd32
11 years ago

@wonderboymusic can you squeeze PR1423 into the monkeypatching too?
It's what's needed for fixing #31058 for 4.2+ (or we can just apply [31444] to trunk as well and be done with it)

#4 @wonderboymusic
11 years ago

@dd32: on it

@wonderboymusic
11 years ago

Attachment 4.2.monkey.2.diff added

#5 @wonderboymusic
11 years ago

Resolution → fixed
Status new → closed

Note: See TracTickets for help on using tickets.

Download in other formats: