Any wp_editor instances would break on RTL languages

[maimairel]

Hi there, there's an issue with RTL languages and additional wp_editor instances. I'll describe the two things that happened on this ticket.

1. When adding any additional wp_editor instances on RTL languages, the function _mce_set_direction would produce a PHP warning.

This is caused by wp-includes/functions.php, line 2904 on WP 4.1.1:

$input['plugins'] .= ',directionality';

This is because the settings array in _WP_Editors::editor_settings does not have the plugins property anymore after the first init.

2. The fatal issue would be this one, where the code in step 1 caused another issue on the following initialization JS code.

init = tinyMCEPreInit.mceInit[edId] = tinymce.extend( {}, firstInit, tinyMCEPreInit.mceInit[edId] );

tinymce.extend would normally extend the editor settings object with a plugins property, but because of the code in _mce_set_direction the settings object already has the plugins property with a value of ,directionality

This caused the additional tinymce instance to display the default buttons.

I hope this gets resolved soon!

Thank you!

[azaozz]

Seems we need isset( $input['plugins'] ) there.

[azaozz]

In 31874:

TinyMCE: fix error and PHP warning when adding more than one instance in RTL mode.
Part props maimairel. Fixes #31578.

[nacin]

Replying to azaozz:

In 31874:

TinyMCE: fix error and PHP warning when adding more than one instance in RTL mode.
Part props maimairel. Fixes #31578.

Is there a reason one of these is an strpos and the other is a regex?