#31911 closed defect (bug) (fixed)
Media splitting: just copy the files for build instead of uglifying them
Reported by: |
|
Owned by: |
|
---|---|---|---|
Milestone: | 4.4 | Priority: | normal |
Severity: | normal | Version: | 4.2 |
Component: | Build/Test Tools | Keywords: | has-patch |
Focuses: | javascript | Cc: |
Description (last modified by )
- Don't uglify, just copy like the other watch tasks.
- Only copy the changed files, currently it uglifies all of them.
- Exclude media files from the
all
task. - Clean up the callback a bit.
Attachments (4)
Change History (24)
This ticket was mentioned in Slack in #core by iseulde. View the logs.
10 years ago
#7
@
9 years ago
- Owner set to wonderboymusic
- Resolution set to fixed
- Status changed from new to closed
In 33960:
#8
follow-up:
↓ 9
@
9 years ago
I'm not sure why the *.manifest
files aren't being watched. Shouldn't the browserify
task be run on the media files when the manifests are edited as well?
#9
in reply to:
↑ 8
;
follow-up:
↓ 10
@
9 years ago
- Keywords needs-patch added
- Resolution fixed deleted
- Status changed from closed to reopened
Replying to jdgrimes:
I'm not sure why the
*.manifest
files aren't being watched. Shouldn't thebrowserify
task be run on the media files when the manifests are edited as well?
They should be - the watcher was totally broken, so the fixes above were a start. Not watching them is an oversight, wanna patch it for some easy props?
#10
in reply to:
↑ 9
@
9 years ago
- Keywords has-patch added; needs-patch removed
Replying to wonderboymusic:
Replying to jdgrimes:
I'm not sure why the
*.manifest
files aren't being watched. Shouldn't thebrowserify
task be run on the media files when the manifests are edited as well?
They should be - the watcher was totally broken, so the fixes above were a start. Not watching them is an oversight, wanna patch it for some easy props?
#11
follow-up:
↓ 12
@
9 years ago
one step further, we need the watcher to:
- watch the proper files
- build them into
media-*.js
files - only copy the built files over, not the files in
media/*
I'm not sure how or when we borked this so completely
#12
in reply to:
↑ 11
;
follow-up:
↓ 13
@
9 years ago
Replying to wonderboymusic:
I'm not sure how or when we borked this so completely
wonderboymusic is fired r31629
#13
in reply to:
↑ 12
@
9 years ago
Replying to netweb:
Replying to wonderboymusic:
I'm not sure how or when we borked this so completely
wonderboymusic is fired r31629
I would focus on the Props iseulde...
portion, mostly.
#14
@
9 years ago
- Owner changed from wonderboymusic to iseulde
- Status changed from reopened to assigned
hey @iseulde, welcome back! funny story: you, me, we, at some point, broke this. Still isn't in an ideal state - see comment:11
This ticket was mentioned in Slack in #core by iseulde. View the logs.
9 years ago
#17
@
9 years ago
@wonderboymusic No need to watch the modules, and the built media files are copied through all
. I can't get watchify
to work with grunt-browserify
v 3.8, updating to 4.0 fixes the problem for me.
Makes it pretty fast: Completed in 0.012s at Mon Apr 06 2015 16:46:39 GMT-0400 (EDT)