![(please configure the [header_logo] section in trac.ini)](/chrome/site/your_project_logo.png){kind=logo}
#31911 closed defect (bug) (fixed)
Media splitting: just copy the files for build instead of uglifying them
| Reported by: | iseulde | Owned by: | iseulde |
|---|---|---|---|
| Priority: | normal | Milestone: | 4.4 |
| Component: | Build/Test Tools | Version: | 4.2 |
| Severity: | normal | Keywords: | has-patch |
| Cc: | Focuses: | javascript |
Description (last modified by )
- Don't uglify, just copy like the other watch tasks.
- Only copy the changed files, currently it uglifies all of them.
- Exclude media files from the
alltask. - Clean up the callback a bit.
Attachments (4)
Change History (24)
This ticket was mentioned in Slack in #core by iseulde. View the logs.
11 years ago
#8
follow-up:
↓ 9
@
11 years ago
I'm not sure why the *.manifest files aren't being watched. Shouldn't the browserify task be run on the media files when the manifests are edited as well?
#9
in reply to: ↑ 8
;
follow-up:
↓ 10
@
11 years ago
- Keywords needs-patch added
- Resolution fixed
- Status closed → reopened
Replying to jdgrimes:
I'm not sure why the
*.manifestfiles aren't being watched. Shouldn't thebrowserifytask be run on the media files when the manifests are edited as well?
They should be - the watcher was totally broken, so the fixes above were a start. Not watching them is an oversight, wanna patch it for some easy props?
#10
in reply to: ↑ 9
@
11 years ago
- Keywords has-patch added; needs-patch removed
Replying to wonderboymusic:
Replying to jdgrimes:
I'm not sure why the
*.manifestfiles aren't being watched. Shouldn't thebrowserifytask be run on the media files when the manifests are edited as well?
They should be - the watcher was totally broken, so the fixes above were a start. Not watching them is an oversight, wanna patch it for some easy props?
#11
follow-up:
↓ 12
@
11 years ago
one step further, we need the watcher to:
- watch the proper files
- build them into
media-*.jsfiles - only copy the built files over, not the files in
media/*
I'm not sure how or when we borked this so completely
#12
in reply to: ↑ 11
;
follow-up:
↓ 13
@
11 years ago
Replying to wonderboymusic:
I'm not sure how or when we borked this so completely
wonderboymusic is fired r31629
#13
in reply to: ↑ 12
@
11 years ago
Replying to netweb:
Replying to wonderboymusic:
I'm not sure how or when we borked this so completely
wonderboymusic is fired r31629
I would focus on the Props iseulde... portion, mostly.
#14
@
11 years ago
- Owner changed from to
- Status reopened → assigned
hey @iseulde, welcome back! funny story: you, me, we, at some point, broke this. Still isn't in an ideal state - see comment:11
This ticket was mentioned in Slack in #core by iseulde. View the logs.
11 years ago
#17
@
11 years ago
@wonderboymusic No need to watch the modules, and the built media files are copied through all. I can't get watchify to work with grunt-browserify v 3.8, updating to 4.0 fixes the problem for me.
Makes it pretty fast: Completed in 0.012s at Mon Apr 06 2015 16:46:39 GMT-0400 (EDT)