Twenty Thirteen: Improving i18n for "Continue reading"

[dregad]

When using French translation of 2013 theme, the "More" link is translated from "Continue reading title" to "Continuer la lecture de title".

This is fine, except for the fact that title is wrapped in a span with screen-reader-text class that causes it to be hidden, leading to display of just "Continuer la lecture de" which is an incorrect translation - it should be "Continuer la lecture".

I would like to suggest the following code change in content.php

--- content.php.orig    2015-04-15 15:34:44.186854600 +0200
+++ content.php.new     2015-04-15 15:41:09.645854600 +0200
@@ -41,8 +41,8 @@
                <?php
                        /* translators: %s: Name of current post */
                        the_content( sprintf(
-                               __( 'Continue reading %s <span class="meta-nav">&rarr;</span>', 'twentythirteen' ),
-                               the_title( '<span class="screen-reader-text">', '</span>', false )
+                               __( 'Continue reading<span class="screen-reader-text"> %s</span>&nbsp;<span class="meta-nav">&rarr;</span>', 'twentythirteen' ),
+                               get_the_title()
                        ) );

                        wp_link_pages( array( 'before' => '<div class="page-links"><span class="page-links-title">' . __( 'Pages:', 'twentythirteen' ) . '</span>', 'after' => '</div>', 'link_before' => '<span>', 'link_after' => '</span>' ) );

This would allow moving "de" within the span for the French translation (and maybe others languages too):

'Continuer la lecture<span class="screen-reader-text"> de %s</span>&nbsp;<span class="meta-nav">&rarr;</span>'

I am not sure whether it is correct to put the class name within the translation string. If not, maybe someone more qualified than I am can come up with a better solution for the problem.

[SergeyBiryukov]

Introduced in [30390] (#30178).

This would also apply to Twenty Fourteen and Fifteen, see [30389] (#30176) and [30237] (#30135).

I guess we need one more sprintf() here:

the_content( sprintf(
	/* translators: %s: Name of current post */
	__( 'Continue reading %s <span class="meta-nav">&rarr;</span>', 'twentythirteen' ),
	/* translators: %s: Name of current post */
	sprintf( _x( '%s', 'post name' ), the_title( '<span class="screen-reader-text">', '</span>', false ) )
) );

So that '%s' could be translated as 'de %s'.

[dregad]

Hi Sergey, and thanks for your response.

Replying to SergeyBiryukov:

	sprintf( _x( '%s', 'post name' ), the_title( '<span class="screen-reader-text">', '</span>', false ) )

So that '%s' could be translated as 'de %s'.

Is post name enough context for translators to understand what this is about ?

[SergeyBiryukov]

Replying to dregad:

Is post name enough context for translators to understand what this is about ?

The context is just to separate out the string in case there's another '%s' string in different context somewhere in the theme (currently there isn't). But yeah, it can also be 'name of current post'.

The %s placeholder should also be explained in translator comment above the string.

[lancewillett]

Thanks for the ticket -- we're in freeze for 4.2 but can look at it right away for the next release of the bundled themes (summer 2015).

[dregad]

Hi Lance,

Thanks for your feedback and for taking this into consideration. Summer 2015 is good enough, I applied a quick&dirty patch to my child theme for now so there's no rush for me.

[lancewillett]

Needs a patch.

[obenland]

Why can't it be translated with 'Continuer la lecture<span class="screen-reader-text"> de %s</span>&nbsp;<span class="meta-nav">&rarr;</span>' now?

Or 'Continuer la lecture<span class="screen-reader-text"> de </span>%s&nbsp;<span class="meta-nav">&rarr;</span>' if you want.

[atimmer]

Replying to SergeyBiryukov:

I guess we need one more sprintf() here:

the_content( sprintf(
	/* translators: %s: Name of current post */
	__( 'Continue reading %s <span class="meta-nav">&rarr;</span>', 'twentythirteen' ),
	/* translators: %s: Name of current post */
	sprintf( _x( '%s', 'post name' ), the_title( '<span class="screen-reader-text">', '</span>', false ) )
) );

This solution doesn't solve the problem raised in the ticket, de would still be outside of the screen-reader-text span.

31979.diff is simply the patch proposed in the OP applied to all three themes.

[obenland]

I really don't think we need to change anything in the translation string in Twenty Thirteen. HTML tags don't get stripped, so the french translation can just add screen reader text spans as needed, like I mentioned in my comment above.

[obenland]

@dregad: There shouldn't be any code change necessary, you can use the following translation to make it work in French: 'Continuer la lecture<span class="screen-reader-text"> de %s</span>&nbsp;<span class="meta-nav">&rarr;</span>'.

[dregad]

@obenland thanks for the feedback. I'm fine with your approach of fixing this through translation instead of code.

I can make the necessary changes locally, no problem, but aren't you going to fix this translation globally and release an update to the plugin ?

[dregad]

I confirm that @obenland's suggestion fixes the display issue I originally reported.

However, I wanted to bring to your attention that the HTML generated after updating the translation now has 2 "screen-reader-text" <span> tags, one within the other as shown below

<a href="http://example.com/2015/06/article/#more-860" class="more-link">
  Continuer la lecture
  <span class="screen-reader-text"> de 
     <span class="screen-reader-text">Titre de l'article</span>
  </span>
  &nbsp;<span class="meta-nav">→</span>
</a>

I am not sure whether that would have any impact on processing by a screen reader.

[obenland]

You could also translate it with 'Continuer la lecture<span class="screen-reader-text"> de </span>%s&nbsp;<span class="meta-nav">&rarr;</span>' to avoid that.

[xibe]

Hey there. As mentioned on Slack, I validated the string changes (even though GlotPress screamed murder, saying "Too many tags in translation").

In truth, I'm not too keen on having more code in the translation than there is in the original string (as does GlotPress, hence its warning). I am surprised the recommendation would be to do that. I do hope this ticket end up in a fix landing in the original strings.

[SergeyBiryukov]

Replying to xibe:

In truth, I'm not too keen on having more code in the translation than there is in the original string (as does GlotPress, hence its warning). I am surprised the recommendation would be to do that. I do hope this ticket end up in a fix landing in the original strings.

The suggested fix is now implemented in Twenty Sixteen: ​https://github.com/WordPress/twentysixteen/pull/383.