#32001 closed defect (bug) (fixed)
Twenty Fifteen: Use default comments_popup_link()
Reported by: |
|
Owned by: |
|
---|---|---|---|
Milestone: | 4.3 | Priority: | normal |
Severity: | normal | Version: | 4.2 |
Component: | Bundled Theme | Keywords: | has-patch |
Focuses: | Cc: |
Description
Function comments_popup_link()
now supports plural function _n()
, see #26553.
Could we use it for Twenty Fifteen? See attached patch.
I am not sure about backward compatibility, but it should not be a problem?
We can fix missing plural form in Twenty Fifteen and also remove some not needed strings (and also add screen reader HTML).
Attachments (2)
Change History (13)
#2
@
10 years ago
Yes, I would vote for Leave a comment
directly in comments_popup_link()
.
This function should be generally usable in themes and Twenty Fifteen could encourage it.
There is no need for special theme strings and localization when we have it in core with screen readers HTML.
It could be also applied to Twenty Fourteen, I guess...
This ticket was mentioned in Slack in #core by helen. View the logs.
10 years ago
This ticket was mentioned in Slack in #core by helen. View the logs.
10 years ago
#8
@
10 years ago
- Keywords has-patch added
- Owner changed from SergeyBiryukov to obenland
- Status changed from assigned to accepted
'Leave a comment'
should probably not be removed, the default string is'No Comments'
.Or we could change the default string for zero comments to
'Leave a comment'
.