Make WordPress Core

Opened 6 years ago

Closed 5 years ago

Last modified 5 years ago

#32001 closed defect (bug) (fixed)

Twenty Fifteen: Use default comments_popup_link()

Reported by: pavelevap Owned by: obenland
Milestone: 4.3 Priority: normal
Severity: normal Version: 4.2
Component: Bundled Theme Keywords: has-patch
Focuses: Cc:


Function comments_popup_link() now supports plural function _n(), see #26553.

Could we use it for Twenty Fifteen? See attached patch.

I am not sure about backward compatibility, but it should not be a problem?

We can fix missing plural form in Twenty Fifteen and also remove some not needed strings (and also add screen reader HTML).

Attachments (2)

32001.patch (652 bytes) - added by pavelevap 6 years ago.
32001.diff (746 bytes) - added by obenland 5 years ago.

Download all attachments as: .zip

Change History (13)

6 years ago

#1 @SergeyBiryukov
6 years ago

'Leave a comment' should probably not be removed, the default string is 'No Comments'.

Or we could change the default string for zero comments to 'Leave a comment'.

#2 @pavelevap
6 years ago

Yes, I would vote for Leave a comment directly in comments_popup_link().

This function should be generally usable in themes and Twenty Fifteen could encourage it.

There is no need for special theme strings and localization when we have it in core with screen readers HTML.

It could be also applied to Twenty Fourteen, I guess...

This ticket was mentioned in Slack in #core by helen. View the logs.

6 years ago

#4 @obenland
6 years ago

  • Keywords 4.3-early added
  • Milestone changed from Awaiting Review to Future Release

#5 @obenland
5 years ago

  • Owner set to SergeyBiryukov
  • Status changed from new to assigned

#6 @obenland
5 years ago

  • Keywords 4.3-early removed
  • Milestone changed from Future Release to 4.3

This ticket was mentioned in Slack in #core by helen. View the logs.

5 years ago

5 years ago

#8 @obenland
5 years ago

  • Keywords has-patch added
  • Owner changed from SergeyBiryukov to obenland
  • Status changed from assigned to accepted

#9 @obenland
5 years ago

  • Resolution set to fixed
  • Status changed from accepted to closed

In 33003:

Twenty Fifteen: Use default strings for comments link.

Also adds context for screen readers, like in default strings.

Props pavelevap for initial patch.
Fixes #32001.

#10 @pavelevap
5 years ago

Textdomain twentyfifteen is missing?

Should not be string "Leave a comment" direct part of comments_popup_link() function as a better choice?

#11 @obenland
5 years ago

In 33005:

Twenty Fifteen: Add missing textdomain.

Props pavelevap.
See #32001.

Note: See TracTickets for help on using tickets.