WordPress.org

Make WordPress Core

Opened 3 years ago

Last modified 3 years ago

#32097 new defect (bug)

Extra margin in `post_submit_meta_box()` on non-public post types

Reported by: dlh Owned by:
Milestone: Awaiting Review Priority: normal
Severity: normal Version: 4.2
Component: Administration Keywords: needs-patch
Focuses: ui Cc:

Description

If you're editing a published or scheduled post in a post type registered with public => false, there's now some extra space above "Status."

Attachments (2)

Edit_Private_Post_‹_WordPress_Trunk_—_WordPress.jpg (135.7 KB) - added by dlh 3 years ago.
32097.patch (763 bytes) - added by dlh 3 years ago.

Download all attachments as: .zip

Change History (8)

#1 @DrewAPicture
3 years ago

  • Component changed from General to Administration
  • Keywords needs-patch added

Hi @dlh, care to add a patch?

#2 follow-up: @dlh
3 years ago

@DrewAPicture: Sure. Does the <span class="spinner"></span> need to always render for backwards compatibility?

#3 in reply to: ↑ 2 @DrewAPicture
3 years ago

Replying to dlh:

@DrewAPicture: Sure. Does the <span class="spinner"></span> need to always render for backwards compatibility?

Mot sure. @helen might be a better person to ask, so mentioning her here.

This ticket was mentioned in Slack in #core by dlh. View the logs.


3 years ago

#5 @helen
3 years ago

I don't know if other people are doing things with that spinner; I don't think it's the end of the world to hide it if the other buttons aren't there. I suppose it's tied to the Save Draft button.

@dlh
3 years ago

#6 @dlh
3 years ago

Patch attached that goes the route of including the markup based on the post status.

Note: See TracTickets for help on using tickets.