Make WordPress Core

Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#32418 closed defect (bug) (fixed)

WP_Embed::maybe_run_ajax_cache not registered for edit_page_form action

Reported by: enrik Owned by: wonderboymusic
Milestone: 4.4 Priority: normal
Severity: normal Version: 4.2.2
Component: Embeds Keywords:
Focuses: administration Cc:


Currently, the oembed cache seems to be only refreshed after saving posts but not after saving pages. No idea if this is like so by intention ...

Nice to have: never use negative cache entries ({{unknown}}) from within the (page) editor. For example, if a youtube link has become {{unknown}} for one or another reason, it will never work even when you re-renter and re-enter it correctly.

Change History (4)

#1 @wonderboymusic
3 years ago

  • Milestone changed from Awaiting Review to 4.4

#2 @wonderboymusic
3 years ago

  • Owner set to wonderboymusic
  • Resolution set to fixed
  • Status changed from new to closed

In 33642:

WP_Embed::maybe_run_ajax_cache() doesn't hook to pages, because it only happens on 'edit_form_advanced', not 'edit_page_form'. Make sure it runs for pages as well. This was probably not intentional, see [29557].

Fixes #32418.

#3 @wonderboymusic
3 years ago

Thanks for the report, @enrik - Keep them coming!

#4 @Viper007Bond
3 years ago

This was probably not intentional

Nope, it wasn't. Good catch.

Note: See TracTickets for help on using tickets.