WordPress.org
Get WordPress

Make WordPress Core

Opened 11 years ago

Closed 11 years ago

#32677 closed defect (bug) (fixed)

Customizer Menus: Accordion toggle in available menu items panel fails on first attempt after a search

Reported by: tywayne Owned by: ocean90
Priority: normal Milestone: 4.3
Component: Customize Version: 4.3
Severity: normal Keywords: needs-patch
Cc: Focuses:

Description

Steps to reproduce:

  1. Click Add Items when editing a menu
  2. Use the search field, doesn't matter if it returns results or not.
  3. Attempt to toggle one of the accordion items below.

gif of process here: ​https://cloudup.com/c2w8vM4sheu

Attachments (1)

32677.diff​ (530 bytes ) - added by tywayne 11 years ago.

Download all attachments as: .zip

Change History (4)

#1 @tywayne
11 years ago

After looking further, it appears this is happening because we're triggering debounceSearch on both the input and change events. Is there a reason we need to trigger a search on both of those events? The change event is firing when the input loses focus, thus opening the search results again.

Removing the change event in api.Menus.AvailableMenuItemsPanelView seems to fix it, but it may be there for a reason I'm not seeing.

#2 @ocean90
11 years ago

  • Keywords needs-patch added
  • Milestone Awaiting Review → 4.3

Related comment by @aferica: ​https://wordpress.slack.com/archives/core-customize/p1434409353000585

@tywayne
11 years ago

#3 @ocean90
11 years ago

  • Owner set to ocean90
  • Resolution → fixed
  • Status new → closed

In 32824:

Customizer: Fix keyboard events for the menu items search field.

Replace the change event with keyup, see https://core.trac.wordpress.org/ticket/26600#comment:59 for background.

props tywayne.
fixes #32677.

Note: See TracTickets for help on using tickets.