Customizer Menus: add QUnit tests

[designsimply]

The Customizer Menus feature needs QUnit tests.

Moved from ​https://github.com/voldemortensen/menu-customizer/issues/68

[celloexpressions]

Who's up for tackling these?

[obenland]

Why is there no patch on this yet?

[westonruter]

Help needed.

[jorbin]

I'm working on getting some tests here, though it would be really helpful if someone more intimate with this code wrote them. My above patch starts adding the code needed to run tests without actually adding any tests. That's next. Hints, tips and pointers are appreciated.

[adamsilverstein]

Start adding some tests

[adamsilverstein]

svn add new files

[adamsilverstein]

Thanks @jorbin for getting this started. I'm going to start writing some tests!

In 32688.3.diff​:

• Add test to verify that generatePlaceholderAutoIncrementId generates unique IDs
• Add some more setup steps, include menu customizer, add window.wpNavMenu setup

Replying to jorbin:

I'm working on getting some tests here, though it would be really helpful if someone more intimate with this code wrote them. My above patch starts adding the code needed to run tests without actually adding any tests. That's next. Hints, tips and pointers are appreciated.

[adamsilverstein]

add defaults setup test

[jorbin]

I am getting this cleaned up so we can get some tests added now. I think the next step needs to be testing some of the api.Menus.MenuItemControl pieces, such as move left, move right, move up, and move down. _changeDepth and _changePosition both throw errors, we should use ​throws to make sure that they are properly thrown when those error conditions exist.

[jorbin]

In 33451:

Add Initial JS Unit Tests for Menu Customizer

While these two tests will help ensure we don't repeat our mistakes, they mostly help lay the foundation for more tests that still need to be written.

See #32688
Props adamsilverstein, jorbin

[jorbin]

Above patch continues to spec out the fixture and adds an additional test, however it also causes many of the existing panel and settings tests to fail.

[westonruter]

Additional change: ​https://github.com/xwp/wordpress-develop/commit/3443f080487dbbfbf5f96e20187f4c2f1abd8bff

[westonruter]

Replying to jorbin:

Above patch continues to spec out the fixture and adds an additional test, however it also causes many of the existing panel and settings tests to fail.

Trivial fix for this in 32688.6.diff​: we just have to extend the window._wpCustomizeSettings.sections object instead of overriding it.

PR with all patches: ​https://github.com/xwp/wordpress-develop/pull/107

[westonruter]

Additional changes: ​https://github.com/xwp/wordpress-develop/compare/3443f08...8ade858

[westonruter]

In 32688.7.diff​: flesh out fixtures for nav menus and add test for non-empty menus, add todos for tests, remove setup/teardown resets for now.

[westonruter]

Additional changes: ​https://github.com/xwp/wordpress-develop/compare/8ade858...3fe53c2a

[westonruter]

Well, I feel like 32688.8.diff​ may be as far as we can take QUnit tests for Menu Customizer in 4.3. Beside the limited time left, the Menu Customizer functionality really begs for integration/acceptance tests and not pure unit tests (even the PHPUnit tests in Core are often not pure unit tests either). I think what we really need to fully test the Customizer is a testing approach that has a real environment (i.e. the vanilla environment created for initial PHPUnit test state) which allows JS to access data provided by PHP at page load time, *and* via Ajax requests, and evaluate the ability to perform end-to-end workflow operations on menus in the Customizer. This is something I've talked about with @jorbin to start writing Selenium scripts to run through the Customizer in the various acceptance tests.

So I suggest that the patch here be committed and we close this out to then turn focus in JS testing to writing acceptance tests.

[obenland]

@ocean90, @markjaquith, can @westonruter get the go-ahead here? It would be nice to have that fixed with RC2.

[markjaquith]

Yeah, go for it. Passing tests should always be good to go, as they don't affect /build/.

[jorbin]

Patch looks good to me.

[westonruter]

In 33528:

Customizer: Add QUnit tests for menus.

Props adamsilverstein, westonruter, jorbin.
Fixes #32688.

[iseulde]

In 33562:

JSHint for [33528]: remove logging

See #32688.