Make WordPress Core

Opened 11 years ago

Closed 11 years ago

#32883 closed defect (bug) (fixed)

Menu Customizer: available menu items (and widgets) after preview iframe should be really hidden and out of tab order

Reported by: afercia Owned by: ocean90
Priority: normal Milestone: 4.3
Component: Customize Version: 4.3
Severity: normal Keywords: has-patch
Cc: Focuses: accessibility

Description

The available Menu Items panel (and also the available Widgets panel) are placed in the HTML source after the preview iframe. They're hidden because they're just out of view but still focusable.

To reproduce, navigate the Customizer using your keyboard and tab through all the elements in the preview until you reach the last focusable element, e.g. like in the screenshot below:

https://cldup.com/Evxrkzl2_m.png

Now keep tabbing and you will notice there are several tab stops before you can actually reach the end of the page. You're actually navigating through all the available Widgets and the available Menu Items controls.

Screen readers will announce all this content since it's actually "visible" for assistive technologies.

The Customizer is already using visibility: hidden to hide hidden elements from keyboard focus and screen readers, see 33069 and that should be applied here too.

Attachments (1)

32883.patch (1.9 KB ) - added by afercia 11 years ago.

Download all attachments as: .zip

Change History (4)

@afercia
11 years ago

#1 @afercia
11 years ago

  • Keywords has-patch added

#2 @valendesigns
11 years ago

@afercia I'll test this patch for you tomorrow :)

#3 @ocean90
11 years ago

  • Owner set to ocean90
  • Resolutionfixed
  • Status newclosed

In 33136:

Customizer: Use visibility to hide available widgets and menu items panels from screen readers and to move them out of tab order.

props afercia.
fixes #32883.

Note: See TracTickets for help on using tickets.