WordPress.org

Make WordPress Core

Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#33239 closed defect (bug) (fixed)

Missing singular for deleting plugins

Reported by: pavelevap Owned by: ocean90
Milestone: 4.4 Priority: normal
Severity: normal Version:
Component: I18N Keywords: needs-patch
Focuses: Cc:
PR Number:

Description

The selected plugins have been <strong>deleted</strong>.

We should have singular and plural forms for this string. When you delete only one plugins (by clicking on delete link) you will get plural notice. One user showed me this string and told me he was afraid of what was really deleted :-) He deleted only one plugin, but WordPress told him, that plugins were deleted...

Attachments (2)

33239.1.patch (1021 bytes) - added by jmayhak 4 years ago.
33239.2.patch (716 bytes) - added by ocean90 4 years ago.

Download all attachments as: .zip

Change History (15)

#1 @ocean90
4 years ago

  • Keywords needs-patch added
  • Milestone changed from Awaiting Review to Future Release
  • Type changed from defect (bug) to enhancement
  • Version trunk deleted

@jmayhak
4 years ago

#2 @jmayhak
4 years ago

  • Keywords has-patch needs-testing added; needs-patch removed

#3 @johnbillion
4 years ago

  • Milestone changed from Future Release to 4.4
  • Owner set to johnbillion
  • Status changed from new to reviewing

#4 @wonderboymusic
4 years ago

  • Owner changed from johnbillion to wonderboymusic
  • Status changed from reviewing to accepted

#5 @wonderboymusic
4 years ago

  • Resolution set to fixed
  • Status changed from accepted to closed

In 34475:

Plugins: on the plugins admin screen, the "has been deleted" string needs a plural.

Props jmayhak.
Fixes #33239.

#6 @pavelevap
4 years ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

We are not using _n() in similar strings, when count is not part of the string, see example:

Plugin <strong>activated</strong>.

Selected plugins <strong>activated</strong>.

Also wording should respect the current pattern...

#7 @ocean90
4 years ago

  • Keywords needs-patch added; has-patch needs-testing removed
  • Type changed from enhancement to defect (bug)

@wonderboymusic Please read #28502 for why [34475] is the wrong approach.

@ocean90
4 years ago

#8 @ocean90
4 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 34521:

Plugins: Don't use _n() for singular/plural strings which have no placeholder for a number.

Fixes #33239.
See #28502.

#9 @pavelevap
4 years ago

@ocean90: Strings should respect current pattern for all others, for example "activated", "deactivated", etc? So, something like this:

Plugin <strong>deleted</strong>.

Selected plugins <strong>deleted</strong>.

#10 @johnbillion
4 years ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

This has introduced a PHP notice after deleting a plugin and being redirected to example.com/wp-admin/network/plugins.php?deleted=1:

Notice: Undefined variable: plugins_to_delete in ~/wp-admin/plugins.php on line 473

#11 @wonderboymusic
4 years ago

  • Owner changed from wonderboymusic to ocean90
  • Status changed from reopened to assigned

#12 @SergeyBiryukov
4 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 34591:

Network Admin: Properly pass the number of delete plugins to the corresponding message.

Fixes #33239.

This ticket was mentioned in Slack in #core-i18n by johnbillion. View the logs.


4 years ago

Note: See TracTickets for help on using tickets.