Make WordPress Core

Opened 10 years ago

Closed 10 years ago

Last modified 10 years ago

#33436 closed defect (bug) (fixed)

Return statement in WP_List_Table::handle_row_actions() doesn't match output.

Reported by: thefan2's profile thefan2 Owned by: drewapicture's profile DrewAPicture
Milestone: 4.4 Priority: normal
Severity: normal Version: 4.3
Component: Administration Keywords: has-patch
Focuses: docs Cc:

Description

WordPress core revision 33590 updated file /wp-admin/includes/class-wp-list-table.php. The @return description @1258 (above handle_row_actions() function) should be updated, too.

Attachments (2)

33436.diff (1.0 KB) - added by morganestes 10 years ago.
Updates @return description for WP_List_Table::handle_row_actions and use strict equality checks
33436.2.diff (816 bytes) - added by morganestes 10 years ago.
Docs-only patch

Download all attachments as: .zip

Change History (6)

@morganestes
10 years ago

Updates @return description for WP_List_Table::handle_row_actions and use strict equality checks

#1 @morganestes
10 years ago

  • Component changed from General to Administration
  • Focuses docs added
  • Keywords has-patch added
  • Summary changed from Outdated documentation to Return statement in WP_List_Table::handle_row_actions() doesn't match output.
  • Version changed from trunk to 4.3

#2 @DrewAPicture
10 years ago

  • Milestone changed from Awaiting Review to 4.4

@morganestes: Let's do the strict equality check in a separate ticket, just to keep the docs and code changes separate. The docs change looks fine.

#3 @DrewAPicture
10 years ago

  • Owner set to DrewAPicture
  • Resolution set to fixed
  • Status changed from new to closed

In 33668:

Docs: Clarify the different return conditions in the DocBlock for WP_List_Table->handle_row_actions().

This clarification follows the introduction of primary columns in 4.3. See #33313.

Props morganestes.
Fixes #33436.

@morganestes
10 years ago

Docs-only patch

#4 @morganestes
10 years ago

Doh, ignore that 2nd screwy patch. :/

Note: See TracTickets for help on using tickets.