WordPress.org

Make WordPress Core

Opened 2 years ago

Last modified 4 months ago

#33573 new enhancement

Use the site icon introduced in 4.3 for the My Sites page

Reported by: morganestes Owned by:
Milestone: Awaiting Review Priority: low
Severity: normal Version: 4.3
Component: Administration Keywords: ui-feedback has-patch has-screenshots
Focuses: ui, multisite Cc:

Description

Now that site icons are available in core, we should be able to use them on the network sites/my sites list.

Attachments (5)

site-icons-in-network-table.patch (1.0 KB) - added by desrosj 2 years ago.
Adjusts the network sites table to show icons.
site-icons-in-network-table2.patch (1.1 KB) - added by desrosj 2 years ago.
Updated patch with favicon sized icon image
33573.diff (1.4 KB) - added by desrosj 14 months ago.
Refreshed patch.
Screen Shot 2016-10-01 at 10.37.54 AM.png (116.1 KB) - added by desrosj 14 months ago.
Before patch
Screen Shot 2016-10-01 at 10.35.51 AM.png (165.4 KB) - added by desrosj 14 months ago.
After patch

Download all attachments as: .zip

Change History (16)

This ticket was mentioned in Slack in #design by morganestes. View the logs.


2 years ago

#2 @DrewAPicture
2 years ago

  • Focuses administration removed
  • Keywords needs-patch added

Cool idea.

@desrosj
2 years ago

Adjusts the network sites table to show icons.

#3 @desrosj
2 years ago

My patch adds a column to the wp-admin/network/sites.php page.

We will need to decide what size we want to include here and adjust the patch, as well as add width and height attributes to the image tag and some styling to the column to prevent it from being too wide.

#4 @johnbillion
2 years ago

  • Keywords ui-feedback added
  • Priority changed from normal to low
  • Version changed from trunk to 4.3

I think this should be shown at favicon size next to the site URL.

@desrosj
2 years ago

Updated patch with favicon sized icon image

This ticket was mentioned in Slack in #core-multisite by jeremyfelt. View the logs.


18 months ago

#6 @Presskopp
18 months ago

  • Keywords has-patch added; needs-patch removed

#7 @desrosj
14 months ago

  • Keywords needs-refresh added

@desrosj
14 months ago

Refreshed patch.

#8 @desrosj
14 months ago

  • Keywords needs-refresh removed

#9 @desrosj
14 months ago

  • Keywords has-screenshots added

The refreshed ticket takes care of desktop, but what should we do on mobile? If we want to show it on mobile as well, some styling adjustments will need to be made.

Also, I set the alt text to the same thing that shows in the URL column. Not sure if there is something like "Site Icon" would be more appropriate.

#10 @karmatosed
11 months ago

My gut says we maybe wouldn't show it on mobile. However, that could be because I'm assuming complication visual wise. Do you have a mockup of what it would look like on mobile?

Just so we're clear the blue background is also images not something your patch adds? I'm judging on screenshots not a patch in this comment @desrosj.

This ticket was mentioned in Slack in #design by karmatosed. View the logs.


4 months ago

Note: See TracTickets for help on using tickets.