WordPress.org

Make WordPress Core

Opened 5 years ago

Last modified 11 months ago

#33573 new enhancement

Use the site icon introduced in 4.3 for the My Sites page

Reported by: morganestes Owned by:
Milestone: Future Release Priority: low
Severity: normal Version: 4.3
Component: Administration Keywords: has-patch has-screenshots
Focuses: ui, multisite Cc:

Description

Now that site icons are available in core, we should be able to use them on the network sites/my sites list.

Attachments (5)

site-icons-in-network-table.patch (1.0 KB) - added by desrosj 5 years ago.
Adjusts the network sites table to show icons.
site-icons-in-network-table2.patch (1.1 KB) - added by desrosj 5 years ago.
Updated patch with favicon sized icon image
33573.diff (1.4 KB) - added by desrosj 4 years ago.
Refreshed patch.
Screen Shot 2016-10-01 at 10.37.54 AM.png (116.1 KB) - added by desrosj 4 years ago.
Before patch
Screen Shot 2016-10-01 at 10.35.51 AM.png (165.4 KB) - added by desrosj 4 years ago.
After patch

Download all attachments as: .zip

Change History (21)

This ticket was mentioned in Slack in #design by morganestes. View the logs.


5 years ago

#2 @DrewAPicture
5 years ago

  • Focuses administration removed
  • Keywords needs-patch added

Cool idea.

@desrosj
5 years ago

Adjusts the network sites table to show icons.

#3 @desrosj
5 years ago

My patch adds a column to the wp-admin/network/sites.php page.

We will need to decide what size we want to include here and adjust the patch, as well as add width and height attributes to the image tag and some styling to the column to prevent it from being too wide.

#4 @johnbillion
5 years ago

  • Keywords ui-feedback added
  • Priority changed from normal to low
  • Version changed from trunk to 4.3

I think this should be shown at favicon size next to the site URL.

@desrosj
5 years ago

Updated patch with favicon sized icon image

This ticket was mentioned in Slack in #core-multisite by jeremyfelt. View the logs.


4 years ago

#6 @Presskopp
4 years ago

  • Keywords has-patch added; needs-patch removed

#7 @desrosj
4 years ago

  • Keywords needs-refresh added

@desrosj
4 years ago

Refreshed patch.

#8 @desrosj
4 years ago

  • Keywords needs-refresh removed

#9 @desrosj
4 years ago

  • Keywords has-screenshots added

The refreshed ticket takes care of desktop, but what should we do on mobile? If we want to show it on mobile as well, some styling adjustments will need to be made.

Also, I set the alt text to the same thing that shows in the URL column. Not sure if there is something like "Site Icon" would be more appropriate.

#10 @karmatosed
3 years ago

My gut says we maybe wouldn't show it on mobile. However, that could be because I'm assuming complication visual wise. Do you have a mockup of what it would look like on mobile?

Just so we're clear the blue background is also images not something your patch adds? I'm judging on screenshots not a patch in this comment @desrosj.

This ticket was mentioned in Slack in #design by karmatosed. View the logs.


3 years ago

This ticket was mentioned in Slack in #design by boemedia. View the logs.


23 months ago

#13 @melchoyce
23 months ago

@desrosj Hey, want to take another look at this after 4.9.6?

This ticket was mentioned in Slack in #design by karmatosed. View the logs.


12 months ago

#15 @melchoyce
12 months ago

  • Keywords ui-feedback removed

@desrosj One other question — how does it look if a site doesn't have a favicon chosen?

#16 @jeremyfelt
11 months ago

  • Milestone changed from Awaiting Review to Future Release

Related: #46657, which adds the site icon to the My Sites admin menu.

This would be nice in tandem with that ticket. Moving to future release for now. We can probably get this in 5.3 though.

Note: See TracTickets for help on using tickets.