Theme location x Menu location

[pavelevap]

We are using "Theme Location" and "Theme locations" in admin menu page (and also many help text sentences).

But Customizer uses "Menu locations" and "Menu Locations".

I am not sure what is better, but it should be same.

[DrewAPicture]

We're already pretty standardized on "theme locations" in documentation, and as you said, the help tabs, so I'd go with "Theme Locations".

[egill]

I found ​75 instances of menu location(s), menu-location(s) in the codebase (documentation, css, js, code).
vs
​22 instances of theme location(s), theme-location(s).

Does it still make sense to pick "Theme locations", and in cases like this one do we leave the code alone and only update the documentation?

[sabernhardt]

Another string: the Menus admin page uses "Display location" when editing a menu, which has confused translators (#58629).

[sabernhardt]

Replacing "theme location" and "display location"

[sabernhardt]

I think the help text could be better than what the patch has, but it's a start.

[bridgetwillard]

Is this ticket still valid? What is the "help text [that] could be better] @sabernhardt ?

[sabernhardt]

Help text for Menu Management, with new text underlined

[sabernhardt]

"Menu location" group under Menu Settings heading

[sabernhardt]

Manage Locations tab, with new text (from patch) underlined, both in the Overview help text and in the table header

[sabernhardt]

Theme menu locations pertain to classic themes, such as Twenty Twenty.

[bridgetwillard]

I agree with your text changes, @sabernhardt -- it's definitely more clear to say "theme menu." And I do remember that being an issue for me when I started using native themes instead of Beaver Builder.

[sabernhardt]

I'll mark this for consideration in 7.0 then. I might create a pull request, with the same changes, if that could make it easier to review than the .diff.

[joedolson]

Refreshed patch; no changes.

[joedolson]

I think this makes a lot of sense. Keeping the language we use to talk about user interfaces consistent is always helpful. I think "Menu Locations" is generally clearer, as it is the object being placed being used as the subject.

In my opinion, this is commit-ready.

[joedolson]

In 61648:

Menus: Improve consistency in describing menu locations.

Menu locations are referred to in various places as 'menu location', 'theme location', or 'display location'.

In some cases these are clear, because both menus and locations are described in the same text. But in other cases they are ambiguous.

Clarify ambiguous uses of 'theme location' and 'menu location' in text.

Props pavelevap, sabernhardt, DrewAPicture, egill, bridgetwillard, obenland, joedolson.
Fixes #33743.