Make WordPress Core

Opened 10 years ago

Last modified 5 weeks ago

#33743 new defect (bug)

Theme location x Menu location

Reported by: pavelevap's profile pavelevap Owned by:
Milestone: 7.0 Priority: normal
Severity: normal Version:
Component: Menus Keywords: has-patch needs-copy-review
Focuses: ui-copy Cc:

Description

We are using "Theme Location" and "Theme locations" in admin menu page (and also many help text sentences).

But Customizer uses "Menu locations" and "Menu Locations".

I am not sure what is better, but it should be same.

Attachments (4)

33743.patch (4.5 KB) - added by sabernhardt 2 years ago.
Replacing "theme location" and "display location"
menu-management-help.png (65.0 KB) - added by sabernhardt 5 weeks ago.
Help text for Menu Management, with new text underlined
menu-location-setting.png (16.8 KB) - added by sabernhardt 5 weeks ago.
"Menu location" group under Menu Settings heading
manage-locations-help-and-table-headers.png (62.2 KB) - added by sabernhardt 5 weeks ago.
Manage Locations tab, with new text (from patch) underlined, both in the Overview help text and in the table header

Download all attachments as: .zip

Change History (13)

#1 @DrewAPicture
10 years ago

  • Keywords needs-patch added

We're already pretty standardized on "theme locations" in documentation, and as you said, the help tabs, so I'd go with "Theme Locations".

#2 @egill
10 years ago

I found 75 instances of menu location(s), menu-location(s) in the codebase (documentation, css, js, code).
vs
22 instances of theme location(s), theme-location(s).

Does it still make sense to pick "Theme locations", and in cases like this one do we leave the code alone and only update the documentation?

#3 @obenland
10 years ago

  • Version trunk deleted

#4 @sabernhardt
2 years ago

  • Milestone set to Future Release

Another string: the Menus admin page uses "Display location" when editing a menu, which has confused translators (#58629).

@sabernhardt
2 years ago

Replacing "theme location" and "display location"

#5 @sabernhardt
2 years ago

  • Focuses ui-copy added
  • Keywords has-patch needs-copy-review added; needs-patch removed

I think the help text could be better than what the patch has, but it's a start.

#6 @bridgetwillard
5 weeks ago

Is this ticket still valid? What is the "help text [that] could be better] @sabernhardt ?

@sabernhardt
5 weeks ago

Help text for Menu Management, with new text underlined

@sabernhardt
5 weeks ago

"Menu location" group under Menu Settings heading

@sabernhardt
5 weeks ago

Manage Locations tab, with new text (from patch) underlined, both in the Overview help text and in the table header

#7 @sabernhardt
5 weeks ago

Theme menu locations pertain to classic themes, such as Twenty Twenty.

#8 @bridgetwillard
5 weeks ago

I agree with your text changes, @sabernhardt -- it's definitely more clear to say "theme menu." And I do remember that being an issue for me when I started using native themes instead of Beaver Builder.

#9 @sabernhardt
5 weeks ago

  • Milestone changed from Future Release to 7.0

I'll mark this for consideration in 7.0 then. I might create a pull request, with the same changes, if that could make it easier to review than the .diff.

Note: See TracTickets for help on using tickets.