WordPress.org
Get WordPress

Make WordPress Core

Opened 9 years ago

Last modified 15 months ago

#33743 new defect (bug)

Theme location x Menu location

Reported by: pavelevap's profile pavelevap Owned by:
Milestone: Future Release Priority: normal
Severity: normal Version:
Component: Menus Keywords: has-patch needs-copy-review
Focuses: ui-copy Cc:

Description

We are using "Theme Location" and "Theme locations" in admin menu page (and also many help text sentences).

But Customizer uses "Menu locations" and "Menu Locations".

I am not sure what is better, but it should be same.

Attachments (1)

33743.patch​ (4.5 KB) - added by sabernhardt 15 months ago.
Replacing "theme location" and "display location"

Download all attachments as: .zip

Change History (6)

#1 @DrewAPicture
9 years ago

  • Keywords needs-patch added

We're already pretty standardized on "theme locations" in documentation, and as you said, the help tabs, so I'd go with "Theme Locations".

#2 @egill
9 years ago

I found ​75 instances of menu location(s), menu-location(s) in the codebase (documentation, css, js, code).
vs
​22 instances of theme location(s), theme-location(s).

Does it still make sense to pick "Theme locations", and in cases like this one do we leave the code alone and only update the documentation?

#3 @obenland
9 years ago

  • Version trunk deleted

#4 @sabernhardt
16 months ago

  • Milestone set to Future Release

Another string: the Menus admin page uses "Display location" when editing a menu, which has confused translators (#58629).

@sabernhardt
15 months ago

Replacing "theme location" and "display location"

#5 @sabernhardt
15 months ago

  • Focuses ui-copy added
  • Keywords has-patch needs-copy-review added; needs-patch removed

I think the help text could be better than what the patch has, but it's a start.

Note: See TracTickets for help on using tickets.