WordPress.org

Make WordPress Core

Opened 2 years ago

Closed 9 months ago

#33780 closed defect (bug) (fixed)

Made Check Box label consistent for discussion meta box

Reported by: juhise Owned by: SergeyBiryukov
Milestone: 4.8 Priority: normal
Severity: normal Version:
Component: Text Changes Keywords: has-patch
Focuses: ui, administration Cc:

Description

Check Box label does not have period in any page, but discussion meta box has period in Check Box label. Removing it for making consistency through out the admin.
Refer : http://goo.gl/0VHLV7

Attachments (2)

33780.patch (1.5 KB) - added by juhise 2 years ago.
Path file
Screen Shot 2016-06-04 at 21.03.07.png (400.4 KB) - added by iseulde 17 months ago.

Download all attachments as: .zip

Change History (8)

@juhise
2 years ago

Path file

#1 @juhise
2 years ago

  • Focuses ui administration added
  • Keywords has-patch added

#2 @obenland
2 years ago

  • Version trunk deleted

#3 @iseulde
17 months ago

  • Component changed from Editor to Text Changes

Right, some sentences do have period, some don't. I'm not entirely sure which should and which should not.

#4 @juhise
9 months ago

@iseulde

I think labels should not have periods as the buttons does not have, period means the end of sentence. It seems to be an instruction not a complete sentence.

#5 @SergeyBiryukov
9 months ago

  • Milestone changed from Awaiting Review to 4.8

#6 @SergeyBiryukov
9 months ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 40032:

Text Changes: Remove periods from checkbox labels in Discussion meta box to improve consistency throughout the admin.

Checkbox labels generally don't have periods, unless it's a complete sentence.

Props juhise.
Fixes #33780.

Note: See TracTickets for help on using tickets.