Invalid HTML on wp-signup.php or wp-activate.php with default themes

[jfarthing84]

I don't know if this was indeed invalid 5 years ago as described in #13832, but it's not anymore. You most certainly do get two div tags with an id of "content" when using Twenty Fifteen or Twenty Sixteen while viewing either wp-signup.php or wp-activate.php.

[SergeyBiryukov]

Confirmed. This wasn't an issue with previous themes, as they only had id="content" in content templates, but Twenty Fifteen and Sixteen have it in header.php, which results in this markup:

<div id="content" class="site-content">
<div id="content" class="widecolumn">

Changing Twenty Fifteen is no longer feasible, as that could break child themes. I guess we should change the ID in wp-signup.php and wp-activate.php to something unique to those files.

[jeremyfelt]

Replying to SergeyBiryukov:

I guess we should change the ID in wp-signup.php and wp-activate.php to something unique to those files.

This seems like the route to go.

If anybody is relying on existing behavior for custom signup styling or JS, we could be introducing a breaking change. Though I think the audience actually designing themes for integrated use with these is pretty small. And those specifically using #content to create a custom experience even smaller. :)

We could probably change now and make sure to note it on Make/Core and with the theme team.

[wonderboymusic]

In 34162:

TwentyFifteen|Sixteen themes have a <div id="content"> in the header. Change the <div> IDs in wp-activate.php and wp-signup.php to be unique to each page.

Props jfarthing84.
Fixes #33843.