WordPress.org

Make WordPress Core

Opened 9 years ago

Closed 9 years ago

#3391 closed defect (bug) (fixed)

Can't click Labels for Radio Buttons in Moderation Queue

Reported by: JeremyVisser Owned by: shorty114
Milestone: 2.0.6 Priority: low
Severity: trivial Version: 2.0.5
Component: Administration Keywords:
Focuses: Cc:

Description

In WordPress 2.0.5, with a comment in the moderation queue, go to WordPress Admin → Manage → Awaiting Moderation (x). Try clicking the labels for the radio buttons "Approve", "Spam", "Delete", "Defer until later". That does not work because the IDs and corresponding label elements do not match.

This problem has been fixed for /trunk/, but the 2.0 branch still has the problem. Attached is a patch to fix the problem.

Attachments (1)

moderation.php.diff (2.7 KB) - added by JeremyVisser 9 years ago.
Patch for moderation.php to fix radio button labels.

Download all attachments as: .zip

Change History (6)

@JeremyVisser9 years ago

Patch for moderation.php to fix radio button labels.

comment:1 follow-ups: @shorty1149 years ago

  • Owner changed from anonymous to shorty114
  • Priority changed from normal to low
  • Severity changed from minor to trivial
  • Status changed from new to assigned
  • Type changed from defect to enhancement

I don't this is *absolutely necessary* for 2.0... 2.1 is coming out in ~2 months, can people live without it until then? ;)

Also, I would put the <label> wrapped *around* the input. Can't remember why though.

comment:2 in reply to: ↑ 1 @shorty1149 years ago

Replying to shorty114:

I don't this is *absolutely necessary* for 2.0... 2.1 is coming out in ~2 months, can people live without it until then? ;)

Also, I would put the <label> wrapped *around* the input. Can't remember why though.

Never mind, this is a good patch.

comment:3 in reply to: ↑ 1 @JeremyVisser9 years ago

  • Type changed from enhancement to defect

Replying to shorty114:

Also, I would put the <label> wrapped *around* the input. Can't remember why though.

The reason I didn't do that is because I'm fixing it the same way Matt fixed it for 2.1.

comment:4 @markjaquith9 years ago

Remember, just because 2.1 is coming out, that doesn't mean 2.0 development is dying! Appreciate that you patched it to sync with 2.1

comment:5 @markjaquith9 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

(In [4531]) ID fixes to allow label clicking in the moderation queue, from JeremyVisser. fixes #3391

Note: See TracTickets for help on using tickets.