Make WordPress Core

Opened 11 years ago

Closed 11 years ago

#34145 closed enhancement (fixed)

Revisit default font settings in wp-activate.php

Reported by: jeremyfelt Owned by: jeremyfelt
Priority: normal Milestone: 4.4
Component: Login and Registration Version: 3.0
Severity: normal Keywords: has-patch ui-feedback
Cc: Focuses: multisite

Description

In wp-activate.php, we have a set of default styles that have been applied since MU.

<style type="text/css">
	form { margin-top: 2em; }
	#submit, #key { width: 90%; font-size: 24px; }
	#language { margin-top: .5em; }
	.error { background: #f66; }
	span.h3 { padding: 0 8px; font-size: 1.3em; font-family: "Lucida Grande", Verdana, Arial, "Bitstream Vera Sans", sans-serif; font-weight: bold; color: #333; }
</style>

Most still make sense as sane defaults, though font-family is a bit forceful rather than falling back to the theme's (and then browser's) default text settings.

I think we can remove font-family and color entirely. padding, font-size, and font-weight all make sense in context.

See screenshots for before/after in Twenty Fifteen.

Somewhat related: #18020, #16298, #8352.

Attachments (3)

34145.diff​ (562 bytes ) - added by jeremyfelt 11 years ago.
twentyfifteen-activate-after-34145-diff.png​ (44.3 KB ) - added by jeremyfelt 11 years ago.
Twenty Fifteen after removing the styles
twentyfifteen-activate-before-34145-diff.png​ (44.1 KB ) - added by jeremyfelt 11 years ago.
Twenty Fifteen with current activation styles

Download all attachments as: .zip

Change History (8)

@jeremyfelt
11 years ago

@jeremyfelt
11 years ago

Twenty Fifteen after removing the styles

@jeremyfelt
11 years ago

Twenty Fifteen with current activation styles

#1 @jeremyfelt
11 years ago

  • Owner set to jeremyfelt
  • Status new → assigned

This ticket was mentioned in ​Slack in #core-multisite by jeremyfelt. ​View the logs.


11 years ago

#3 @toscho
11 years ago

I agree. Lucida Grande is a button font with a very limited set of glyphs. It isn't needed here and may actually cause problems in languages whose letters are not completely covered by that font.

This ticket was mentioned in ​Slack in #core-multisite by jeremyfelt. ​View the logs.


11 years ago

#5 @jeremyfelt
11 years ago

  • Resolution → fixed
  • Status assigned → closed

In 34882:

Registration: Remove the last remaining Lucida Grande from WordPress.

Defer to default styling provided by the theme (and browser) in wp-activate.php and remove the font-family and color from the provided internal stylesheet.

Previously, [17327] and [18406].

Fixes #34145.

Note: See TracTickets for help on using tickets.