Opened 10 years ago
Closed 10 years ago
#34145 closed enhancement (fixed)
Revisit default font settings in wp-activate.php
| Reported by: |
|
Owned by: |
|
|---|---|---|---|
| Milestone: | 4.4 | Priority: | normal |
| Severity: | normal | Version: | 3.0 |
| Component: | Login and Registration | Keywords: | has-patch ui-feedback |
| Focuses: | multisite | Cc: |
Description
In wp-activate.php, we have a set of default styles that have been applied since MU.
<style type="text/css">
form { margin-top: 2em; }
#submit, #key { width: 90%; font-size: 24px; }
#language { margin-top: .5em; }
.error { background: #f66; }
span.h3 { padding: 0 8px; font-size: 1.3em; font-family: "Lucida Grande", Verdana, Arial, "Bitstream Vera Sans", sans-serif; font-weight: bold; color: #333; }
</style>
Most still make sense as sane defaults, though font-family is a bit forceful rather than falling back to the theme's (and then browser's) default text settings.
I think we can remove font-family and color entirely. padding, font-size, and font-weight all make sense in context.
See screenshots for before/after in Twenty Fifteen.
Attachments (3)
Change History (8)
This ticket was mentioned in Slack in #core-multisite by jeremyfelt. View the logs.
10 years ago
#3
@
10 years ago
I agree. Lucida Grande is a button font with a very limited set of glyphs. It isn't needed here and may actually cause problems in languages whose letters are not completely covered by that font.
Twenty Fifteen after removing the styles