Issues with importing/converting blogroll from 2.0.5

[Viper007Bond]

Just upgraded my live blog from 2.0.5 to latest SVN (r4578) and had some issues with blogroll categories.

Everything appears to have been imported just fine (no missing data), however the links were put into some additional categories. All of the links are there and are filed in their original categories, but they are also filed in some of my existing post categories. There doesn't seem to be a pattern as these additional categories were picked, but I may be missing it.

And I'm not going to even bother to speculate what's up -- I'll leave that to someone more in the know with the new blogroll code (I'm not up to date on it yet).

Can provide details as needed.

[Viper007Bond]

After upgrade, before fixing manually

[ryan]

upgrade_210() in upgrade-functions.php is the responsible code if someone wants to give it a look.

[BrianLayman]

I'm a little concerned about the merging code in this area...

Ok, so basicaly, because of the code in admin-db.category_exists, the first category wins. However, since no "order by" clause is specified in that query, we aren't going to know for sure which the "first" category is going to be. At least that's how it would work in a relational DB. The order of the results would be dependant upon the order in which the data was inserted and when it was modified last. So the order could be by ID or it could be by when the user inserted it or if they did a restore it could be the order by which the restore inserted the records.

Additionally, the Category_exists function doesn't cast the stuff to a specific case when checking for an existing name. So we could end up with WordPress and Wordpress categories (as an example) because of how the blogger first typed them in in Posts vs links. I don't know if that's a design choice, or design oversight. Either way could be argued for I suppose, but there are no comments in the code indicating whether this issue was considered.

[BrianLayman]

nm on uppercase/lowercase thing. I see sanitize_title actually converts to lowercase. But I do think an

ORDER BY category_parent , cat_ID

could be added.

[ryan]

I cleaned up the upgrade code a bit and ran some test upgrades with a mix of links and cats. Worked for me. Anyone have a 2.0 DB I can test with?

[mattyrob]

I think this may have been fixed by this similar ticket:

​http://trac.wordpress.org/ticket/4813