WordPress.org

Make WordPress Core

Opened 4 years ago

Closed 4 years ago

#34340 closed enhancement (fixed)

The "you need to log in again" message is awkward

Reported by: chriscct7 Owned by: DrewAPicture
Milestone: 4.5 Priority: normal
Severity: normal Version:
Component: Text Changes Keywords: has-patch has-screenshots commit
Focuses: administration Cc:

Description (last modified by chriscct7)

Currently if your session expires while you're on an admin page, there's an overlay with the message "Session expired. Please log in again. You will not move away from this page."

The phrasing of this message, seems sort of awkward (not sure if it was done this way to make it easier to translate, so someone might have better context on it), but it seems it could be better phrased as "Your session has expired and you need to log in again to continue" or "Session expired. Please log in to continue." or something along those lines

Attachments (4)

34340_login_box.png (31.7 KB) - added by obrienlabs 4 years ago.
34340.diff (643 bytes) - added by obrienlabs 4 years ago.
34340-2.diff (638 bytes) - added by obrienlabs 4 years ago.
34340_after.png (35.7 KB) - added by DrewAPicture 4 years ago.
w/ 34340-2.diff

Download all attachments as: .zip

Change History (18)

#1 @chriscct7
4 years ago

  • Description modified (diff)

#2 @swissspidy
4 years ago

Would be nice to see how similar messages look like in other content management systems.

I found this one from TYPO3:

Your session has expired. You need to log in again if you want to continue. Otherwise you can close the current browser window.

#3 @chriscct7
4 years ago

  • Type changed from defect (bug) to enhancement

@obrienlabs
4 years ago

#4 @obrienlabs
4 years ago

  • Keywords has-patch added; needs-patch removed

I agree the wording is a bit weird. Maybe just keeping it simple? Instead of saying "You will not move away from this page.", what is really meant is that you'll continue where you left off.

Your session has expired. Please log back in to continue where you left off.

#5 @DrewAPicture
4 years ago

  • Milestone changed from Awaiting Review to Future Release

I can get on board with this improvement. Maybe even "Please log in to continue where you left off" for the second sentence would be good enough. "log back in" seems off to me.

Your session has expired. Please log in to continue where you left off.
Last edited 4 years ago by DrewAPicture (previous) (diff)

#6 @DrewAPicture
4 years ago

  • Keywords has-screenshots added

@obrienlabs
4 years ago

#7 @obrienlabs
4 years ago

I actually had that originally, then saw the updated wording of "log back in", and borrowed it. This way reads a little cleaner, so I added a new patch with the updated wording.

Your session has expired. Please log in to continue where you left off.

#8 @DrewAPicture
4 years ago

  • Owner set to DrewAPicture
  • Status changed from new to accepted

Looks good to me. Nice work, @obrienlabs!

I'd be happy to commit this once the 4.5 release gets going (we're past the point for new enhancements in 4.4).

#9 @obrienlabs
4 years ago

Thanks @DrewAPicture - my first one!

#10 @DrewAPicture
4 years ago

  • Keywords 4.5-early added

#11 @chriscct7
4 years ago

  • Keywords ux-feedback removed

#12 @chriscct7
4 years ago

  • Keywords commit added
  • Milestone changed from Future Release to 4.5

Go for launch!

Nice job @obrienlabs!

#13 @DrewAPicture
4 years ago

  • Keywords 4.5-early removed

34340_after.png shows the message with 34340-2.diff applied. Looks great :-)

#14 @DrewAPicture
4 years ago

  • Resolution set to fixed
  • Status changed from accepted to closed

In 35865:

Administration: Improve the message displayed in the login form modal when a user's session has expired.

Props obrienlabs.
Fixes #34340.

Note: See TracTickets for help on using tickets.