Improvements to comment_type function

[dshanske]

comment_type should have a filter for non-standard comment types, and should have, as other functions do, an option to return the text, as opposed to echoing it.

[rachelbaker]

Related #12668

[jgrodel]

Just a quick first attempt. Feedback welcome.

(WCUS)

[rachelbaker]

@dshanske get_comment_type() already allows you to just get the comment_type (without echoing it), can you provide some details around why this other function wouldn't fit your use-case?
I agree that the comment_type is very inflexible, and I like the idea of adding a filter here, but I don't like the idea of adding a fourth parameter.

[dshanske]

@rachelbaker I didn't write the patch. My original point was that there wasn't consistency in the functions compared to similar functions.

My use case was custom comment types. But get_commment_type allows you to get the name of the type, not the presentation name. For example...

'pingback' may be the comment type, but the presentation name might be Pingback or whatever in another language.

Personally, I'd like to deprecate the first three parameters in favor of a filter, but that leads to backward compatibility issues.

[rachelbaker]

@dshanske I think what really needs to happen here is full support for comment types, like we have with Posts. See #35214

[rachelbaker]

Duplicate of #35214.