Make WordPress Core

Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#34577 closed defect (bug) (fixed)

Posts List Table: $mode is null in display_rows() for Quick Edit

Reported by: ocean90 Owned by: ocean90
Milestone: 4.4 Priority: normal
Severity: normal Version:
Component: Posts, Post Types Keywords: has-patch
Focuses: administration Cc:


Set the view mode to excerpt and change a post via Quick Edit.
Expected: You get the excerpt view
Current: You get the list view because the global $mode in WP_Posts_List_Table->display_rows() is null.

$mode gets only defined in WP_Posts_List_Table->prepare_items() which isn't used by wp_ajax_inline_save().

Attachments (3)

34577.patch (2.3 KB) - added by ocean90 5 years ago.
34577.2.patch (1.5 KB) - added by ocean90 5 years ago.
34577.3.patch (1.7 KB) - added by ocean90 5 years ago.

Download all attachments as: .zip

Change History (8)

5 years ago

5 years ago

5 years ago

#2 @ocean90
5 years ago

  • Keywords has-patch added
  • Milestone changed from Awaiting Review to 4.4

This ticket was mentioned in Slack in #core by ocean90. View the logs.

5 years ago

#4 @ocean90
5 years ago

  • Owner set to ocean90
  • Resolution set to fixed
  • Status changed from new to closed

In 35518:

List Tables: Define the global $mode variable for Quick Edit savings.

Also remove two unused global imports for $mode.

Fixes #34577.

#5 @ocean90
5 years ago

In 35531:

After [35518] define $_POST['post_view'] in test_dont_process_terms_if_taxonomy_does_not_allow_show_on_quick_edit().

See #34577.

Note: See TracTickets for help on using tickets.