WordPress.org

Make WordPress Core

Opened 4 years ago

Closed 3 years ago

Last modified 3 years ago

#34789 closed enhancement (fixed)

Timezone Option Terminology Improvement

Reported by: GrantDerepas Owned by: afercia
Milestone: 4.7 Priority: normal
Severity: normal Version:
Component: Text Changes Keywords: has-patch commit
Focuses: ui, accessibility Cc:

Description

It always confused me why the timezone option in General settings sais:

Choose a city in the same timezone as you.

For a long time I didn't even know there was a list of cities in the options dropdown as it defaults to UTC+0 and I would simply scroll from there to UTC+8 (my local timezone).

Even after discovering there is a list of cities in the dropdown I don't think it makes sense for the tooltip to not make mention that there's two possible methods to fill this field (city or timezone).

I'd propose changing the following line in wp-admin/options-general.php

<p class="description" id="timezone-description"><?php _e( 'Choose a city in the same timezone as you.' ); ?></p>

to something like:

<p class="description" id="timezone-description"><?php _e( 'Choose a timezone or a city in the same timezone as you.' ); ?></p>

Attachments (3)

34789.patch (626 bytes) - added by andrew.p 3 years ago.
Small description change in the timezone options
34789.diff (605 bytes) - added by afercia 3 years ago.
34789.2.diff (612 bytes) - added by afercia 3 years ago.

Download all attachments as: .zip

Change History (17)

#1 @ramiy
4 years ago

  • Component changed from Options, Meta APIs to Text Changes

@andrew.p
3 years ago

Small description change in the timezone options

#2 @andrew.p
3 years ago

  • Keywords has-patch added

I also agree that the description is a bit misleading, as the dropdown contains both cities and timezone offsets.

I attach a patch with an improved description text:
Choose a city in the same timezone as you or a UTC timezone offset.

This ticket was mentioned in Slack in #accessibility by rianrietveld. View the logs.


3 years ago

#4 @joedolson
3 years ago

This seems like a good change. It's a minor accessibility issue, but could have an impact for people with cognitive impairments. On the whole, the timezone selector could use a major overhaul - but that should probably be a different issue to address later.

Accessibility team votes yes. :)

#5 @SergeyBiryukov
3 years ago

  • Keywords 4.7-early added
  • Milestone changed from Awaiting Review to Future Release

Related: #10660, #18146, #36591.

This ticket was mentioned in Slack in #meta by andreasp. View the logs.


3 years ago

@afercia
3 years ago

#7 @afercia
3 years ago

  • Keywords commit added; 4.7-early removed
  • Milestone changed from Future Release to 4.7

Patch didn't applied cleanly for me, refreshed.

#8 @johnbillion
3 years ago

  • Keywords 2nd-opinion added; commit removed

That phrase isn't very good English.

Choose a city in the same timezone as you or a UTC timezone offset.

This implies two choices:

  1. Choose a city in the same timezone as you.
  2. Choose a city in the same timezone as a UTC timezone offset.

The phrase needs either a comma before or, or it needs the word either after Choose. My preference is for the latter.

#9 @afercia
3 years ago

Either sounds better to me :) Also would make things more clear for translators.

#10 @afercia
3 years ago

  • Keywords needs-refresh added

@afercia
3 years ago

#11 @afercia
3 years ago

  • Keywords commit added; 2nd-opinion needs-refresh removed

Refreshed patch adding either.

https://cldup.com/tVrR3RLjN4.png

This ticket was mentioned in Slack in #core by afercia. View the logs.


3 years ago

#13 @afercia
3 years ago

  • Owner set to afercia
  • Resolution set to fixed
  • Status changed from new to closed

In 38483:

Text Changes: Improve the timezone setting description in General Settings.

Makes more clear users can set either a city or a UTC timezone offset.

Props GrantDerepas, andrew.p.
Fixes #34789.

This ticket was mentioned in Slack in #meta by andreasp. View the logs.


3 years ago

Note: See TracTickets for help on using tickets.