Improve unnecessary/false checks in sanitize_post_field()

[tfrommen]

Don't check if we're in attribute or JavaScript context if we already know we're in edit or database context.

[tfrommen]

Like 34900.patch, but with all the code formatting optimizations you might wish for. ;)

[swissspidy]

As per ​https://make.wordpress.org/core/2011/03/23/code-refactoring/, code refactoring should not be done for the sake of refactoring.

The check as it currently is doesn't hurt anyone and works.

[tfrommen]

I assumed a reaction like yours, that's why I provided two patches: one just fixing what is done wrong (or at least suboptimal).

I didn't question that it works. I rather stated that it is working in a way that can (and should) be improved.

[tfrommen]

So, will this get closed now, or is there someone who thinks this might be something worth thinking about?

[boonebgorges]

34900.2.patch​ does too much (not all of which is code formatting!) but 34900.patch​ seems close enough to a bug to warrant addressing.

[boonebgorges]

In 37220:

In sanitize_post_field(), only run 'attribute' or 'js' escaping when necessary.

Props tfrommen.
Fixes #34900.