Allow filtering the temporary file name generated by wp_tempnam

[mihaimihai]

The wp_tempnam() function is located in wp-admin/includes/file.php

When you use download_url() to download a zip file from a url that has many GET parameters

e.g. ​http://example.com/?arg1=val1&arg2=val2&arg3=val3 ...... argn=valn,

wp_tmpnam() will generate a name for the temporary file from the list of args.

e.g. arg1val1arg2val2arg3val3......argn=valn.tmp

If this is long enough, on an Windows environment, it can weigh a lot to the limitation of maximum 256 chars for a path.

When copying the contents of the zip file to the wp-content/upgrade folder for instance if the path of the WordPress install + the folder name + any path inside the zip file is longer then 256 chars an error will occur. "Could not create directory"

Suggestion: allow the returned value of wp_tempnam() to be filtered. This will help with avoiding the long path issue with Windows

[dd32]

We won't be adding a filter here, but definitely should avoid long filenames where a real filename is not provided.

[kollega007]

Replying to dd32:

We won't be adding a filter here, but definitely should avoid long filenames where a real filename is not provided.

Hi Dion,

I'm an author on Envato marketplace and I have an issue related to this - Envato Toolkit plugin can't update our theme related to this :( ( Envato API url too long, so tmp file name is too long as well )

May I ask if this fix will be released in nearest versions? Is it included in a roadmap?

I've created a patch, if this helpful...

Please let me back, so I can understand what I able to say to my clients related to this issue.

Thanks,
Oleg

[dd32]

I'll look into this this cycle.

@kollega007 The earliest it'll get fixed is in the 4.6 release, so later this year. You could work around it by serving shorter update URLs.

[kollega007]

Replying to dd32:

I'll look into this this cycle.

@kollega007 The earliest it'll get fixed is in the 4.6 release, so later this year. You could work around it by serving shorter update URLs.

I see, thanks.

Related to usage of shorter URLs - sorry, but I'm not a developer for Envato's API. This is a bug of WP function, so I suppose, it should be fixed on this side.

Thanks that let me back. Have a nice day!

[DrewAPicture]

@dd32 Sounds we're against adding the filter, so how would you proceed with a fix for this?

[dd32]

In 37598:

Updates: Only use the filename component of URLs to form part of the temporary filename.
Previously we were passing the entire URL to wp_tempnam() (incorrectly) which caused the query string to be used as part of the temporary filename.
We now only use the file component of a url such as https://example.com/filename.zip?arg1=1&arg2=2....&arg100=100 to prevent a long filename.

Fixes #34938

[kollega007]

Replying to dd32:

But what if we have ​http://example.com/arg1/1/arg2/2/.../arg100/100/filename.zip ?

In 37598:

Updates: Only use the filename component of URLs to form part of the temporary filename.
Previously we were passing the entire URL to wp_tempnam() (incorrectly) which caused the query string to be used as part of the temporary filename.
We now only use the file component of a url such as https://example.com/filename.zip?arg1=1&arg2=2....&arg100=100 to prevent a long filename.

Fixes #34938

[dd32]

Replying to kollega007:

Replying to dd32:

But what if we have ​http://example.com/arg1/1/arg2/2/.../arg100/100/filename.zip ?

basename() returns the final component of the path.

• filename.zip in the case of http://example.com/arg1/1/arg2/2/.../arg100/100/filename.zip
• filename.zip in the case of http://example.com/filename.zip?arg=1
• directory in the case of http://example.com/directory/?arg1=1&filename=blah.zip

The last case is fine, as it's just a hint for the temporary file, having a generic string there isn't a massive issue.