Confirm weak password checkbox not hidden when process cancelled

[ChemicalSailor]

When changing user password, if a user enters a weak password, then cancels the process, the confirm weak password table row is not re-hidden.

Steps to recreate: Go to profile.php, generate new password, enter a weak password, cancel process

[swissspidy]

Can confirm. The checkbox only goes away when generating a new password or inserting a stronger one manually.

[subharanjan]

Hides and Reset the checkbox "Confirm use of weak password " on click on Cancel button

[swissspidy]

Simplified patch

[swissspidy]

Some additional notes on my patch:

• The if ( $weakCheckbox.prop( 'checked' ) ) check isn't necessary. We can simply uncheck it all the time here.
• normal is not a valid value for .hide(). Using the default value (200ms) leads to the checkbox animation taking longer than the other animation, using 0 makes it more simultaneous.

[ocean90]

34950.2.patch​ looks good.

[subharanjan]

@swissspidy Thanks for correcting the patch. I am sorry with that extra unnecessary if check. However, as per this ​http://www.w3schools.com/jquery/eff_hide.asp the default value seems to be 400ms. Thank you :)

[afercia]

Replying to subharanjan:

the default value seems to be 400ms. Thank you :)

I think setting the duration to 0 it's a way to use the animation syntax (which allows to pass a "complete" callback) and still have the element immediately hidden.

[swissspidy]

In 35870:

Passwords: Hide weak password confirmation checkbox when password strength improves.

Props subharanjan for initial patch.
Fixes #34950.