Opened 9 years ago
Closed 9 years ago
#34953 closed defect (bug) (fixed)
Focus style: Names in credit section
Reported by: |
|
Owned by: |
|
---|---|---|---|
Milestone: | 4.5 | Priority: | normal |
Severity: | normal | Version: | 4.4 |
Component: | Administration | Keywords: | has-patch has-screenshots commit |
Focuses: | ui, accessibility | Cc: |
Description
Focus style on names in credit section are broken. See screenshot.
Attachments (4)
Change History (11)
#3
@
9 years ago
- Keywords has-screenshots commit added
- Milestone changed from Awaiting Review to 4.5
- Owner set to afercia
- Status changed from new to assigned
The refreshed patch tries to simplify a bit the markup. There's no need to have two separate links, they can be combined in just one link for better semantics and accessibility as suggested in https://www.w3.org/TR/WCAG20-TECHS/H2.html
This would be consistent with what was already done on the Media Library screen, also for the focus style. See screenshot below:
- currently, both the gravatar and the name are links
- combined in just one link with the new focus style
- consistent with the focus style in the Media Library
#4
@
9 years ago
Added an empty alt attribute to 34953.2.diff. The alt attribute should be left empty and not deleted.
Version 0, edited 9 years ago
by
(next)
This ticket was mentioned in Slack in #design by afercia. View the logs.
9 years ago
Note: See
TracTickets for help on using
tickets.
@walbo nice catch. Would be great to take this opportunity to improve the markup too. A nice improvement would be removing redundant links and have just one link that wraps both the image and the name. See http://www.w3.org/TR/WCAG20-TECHS/H2.html and discussion on #32254 and #32509.
Basically:
Something like this: