Opened 9 years ago
Closed 9 years ago
#35041 closed enhancement (fixed)
Add visual feedback to reorder link
Reported by: | karmatosed | Owned by: | voldemortensen |
---|---|---|---|
Milestone: | 4.5 | Priority: | normal |
Severity: | normal | Version: | |
Component: | Customize | Keywords: | ux-feedback ui-feedback has-patch |
Focuses: | ui, accessibility | Cc: |
Attachments (1)
Change History (12)
#3
@
9 years ago
- Focuses accessibility added
Actually there are two spans (they're used to change the text depending on the "reordering mode" status) inside a button. As per the hover style, I'm all for improvements. Should be coordinated with the similar button in the Menu Customizer and probably be paired with the focus style?
#4
@
9 years ago
Just added an update for this. The styling affects the .reorder-toggle class which means it will hit both the widget and menu reordering buttons as @afercia mentioned above using the color scheme @melchoyce suggested.
This is already a button with spans inside of it, so no need to update the structure at this time.
Menu:
https://www.dropbox.com/s/6hk2eyo853yabi7/wp-menu-hover.gif?dl=0
Widgets:
https://www.dropbox.com/s/l0jqnj19fnowzy4/wp-widget-hover.gif?dl=0
#6
follow-up:
↓ 8
@
9 years ago
- Keywords has-patch added
@coreymcollins thanks for the patch! Just for future reference, there is no need to update the minified css files. Those are generated with grunt before release. Pretty sure I did the same thing one of my first css patches :)
#8
in reply to:
↑ 6
@
9 years ago
@voldemortensen Thanks for the heads up! I'll keep that in mind for the future.
I think it's because it's a span, not actually a link, so it didn't inherit the correct styles automatically. If we want to just update the colors for clarity, let's use
#0073aa
, and#00a0d2
on hover. However — should this be a<button>
? Any thoughts @afercia?