WordPress.org

Make WordPress Core

Opened 5 years ago

Closed 4 years ago

Last modified 4 years ago

#35314 closed enhancement (fixed)

Background color should be applied to the body element instead of html

Reported by: michaelarestad Owned by: michaelarestad
Milestone: 4.6 Priority: lowest
Severity: trivial Version:
Component: Administration Keywords: has-patch
Focuses: ui, administration Cc:

Description

Currently, the background colour for the admin is applied to html rather than body. This is not ideal. When applied to body, html inherits the colour. I know it sounds backwards, but that's how it works.

If a plugin attempts to add a background colour to body, there will be occasions when both the html background colour and the body background colour are visible at the same time.

I think simply using body is more flexible. I have included a patch.

Attachments (1)

35314.diff (680 bytes) - added by michaelarestad 5 years ago.

Download all attachments as: .zip

Change History (5)

@michaelarestad
5 years ago

#1 @MikeHansenMe
5 years ago

  • Keywords has-patch added

#2 @chriscct7
4 years ago

  • Version trunk deleted

#3 @michaelarestad
4 years ago

  • Owner set to michaelarestad
  • Resolution set to fixed
  • Status changed from new to closed

In 37321:

Component: Administration

Setting the background color on body is more flexible than on the html element. This patch assigns the background color to body instead of the html element.

Fixes #35314

#4 @pento
4 years ago

  • Milestone changed from Awaiting Review to 4.6
Note: See TracTickets for help on using tickets.