WordPress.org

Make WordPress Core

Opened 4 years ago

Closed 4 years ago

Last modified 3 years ago

#35376 closed defect (bug) (fixed)

Default URL for emoji images should be always https

Reported by: ocean90 Owned by: johnbillion
Milestone: 4.4.2 Priority: normal
Severity: normal Version: 4.2
Component: Emoji Keywords: has-patch
Focuses: performance Cc:

Description (last modified by ocean90)

The default URL is currently set_url_scheme( '//s.w.org/images/core/emoji/72x72/' ) but the CDN is SSL-only, so in case set_url_scheme() returns "http" the request gets redirected to "https". That's pretty bad for our little friends.

curl -I http://s.w.org/images/core/emoji/72x72/1f680.png
HTTP/1.1 301 Moved Permanently
Content-Type: text/html
Date: Fri, 08 Jan 2016 19:53:08 GMT
Location: https://s.w.org/images/core/emoji/72x72/1f680.png
Server: nginx
Content-Length: 178

It's seems like this was an oversight in [31938] because s0.wp.com has no such redirect.

h/t: @glueckpress – http://glueckpress.com/7295/schnellere-emoji-wordpress-plugin/

Attachments (1)

35376.patch (956 bytes) - added by ocean90 4 years ago.

Download all attachments as: .zip

Change History (5)

@ocean90
4 years ago

#1 @ocean90
4 years ago

  • Description modified (diff)

#2 @johnbillion
4 years ago

  • Owner set to johnbillion
  • Resolution set to fixed
  • Status changed from new to closed

In 36249:

Emoji: Explictly use https as the scheme for emoji fallback images, as they're only served over HTTPS by the CDN anyway.

Fixes #35376
Props ocean90

#3 @ocean90
3 years ago

In 36428:

Emoji: Explicitly use https as the scheme for emoji fallback images, as they're only served over HTTPS by the CDN anyway.

Merges [36249] to the 4.4 branch.
See #35376.

#4 @ocean90
3 years ago

  • Milestone changed from 4.5 to 4.4.2
Note: See TracTickets for help on using tickets.