Make WordPress Core

Opened 8 years ago

Closed 8 years ago

#35571 closed defect (bug) (fixed)

Update TinyMCE and jQuery UI button styles

Reported by: iseulde's profile iseulde Owned by: iseulde's profile iseulde
Milestone: 4.5 Priority: normal
Severity: normal Version:
Component: General Keywords: has-patch
Focuses: Cc:

Description

Even though there's a big note on top of the buttons.css since [27494], it has been ignored in all the following commits.

We need to update those files, or maybe consider moving the classes to the buttons.css file.

@helen what do you think?

Attachments (4)

35571.patch (62.1 KB) - added by liljimmi 8 years ago.
Updated jquery-ui-dialog.css and editor.css to match changes in buttons.css
35571-2.patch (2.8 KB) - added by liljimmi 8 years ago.
New patch without minified files
35571.2.patch (3.7 KB) - added by iseulde 8 years ago.
35571.3.patch (8.0 KB) - added by iseulde 8 years ago.

Download all attachments as: .zip

Change History (24)

#1 @helen
8 years ago

I don't recall why those styles were left in separate files, but I imagine it had something to do with the styles being loaded in different contexts. How much needs to be synced and are there situations where buttons.css isn't loaded where the other ones are?

#2 @iseulde
8 years ago

Yes, but I guess buttons.css can be made a dependency. We just need to add extra classes to that file. Happy to make a patch to review.

#3 @iseulde
8 years ago

#35612 was marked as a duplicate.

This ticket was mentioned in Slack in #core-editor by iseulde. View the logs.


8 years ago

#5 @afercia
8 years ago

Related: #35604.

#7 @jorbin
8 years ago

  • Owner set to iseulde
  • Status changed from new to assigned

@iseulde Can you make sure the styles get corrected for 4.5?

@liljimmi
8 years ago

Updated jquery-ui-dialog.css and editor.css to match changes in buttons.css

#8 @liljimmi
8 years ago

I used this Diff as a guide to see what changes have been made since the note was added to the top of buttons.css

This ticket was mentioned in Slack in #core by chriscct7. View the logs.


8 years ago

@liljimmi
8 years ago

New patch without minified files

This ticket was mentioned in Slack in #core by chriscct7. View the logs.


8 years ago

This ticket was mentioned in Slack in #core by mike. View the logs.


8 years ago

#12 @kirasong
8 years ago

@iseulde @helen: Can you please review this? Wondering if it's still on track to land for 4.5.

#13 @iseulde
8 years ago

Sure, if it's okay, will do this tomorrow morning (Europe).

#14 @kirasong
8 years ago

+1

Thanks! :D

#15 @iseulde
8 years ago

So we'd rather patch the current files again instead of moving them to buttons.css?

#16 @kirasong
8 years ago

@iseulde Whatever you think is best here. If you'd like to go the dependency route, feel free to either patch/commit that way, or punt.

I don't mind if we commit the current approach (bringing the files up to date), then handle it differently for 4.6, if that makes the most sense.

#17 @helen
8 years ago

In late beta, yes, let's patch a file and not go messing with what depends on which.

This ticket was mentioned in Slack in #core by mike. View the logs.


8 years ago

@iseulde
8 years ago

@iseulde
8 years ago

#19 @iseulde
8 years ago

  • Keywords has-patch added; needs-patch removed

Good for now?

#20 @iseulde
8 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 37076:

Update TinyMCE and jQuery UI button styles

Part props liljimmi.
Fixes #35571.

Note: See TracTickets for help on using tickets.