WordPress.org
Get WordPress

Make WordPress Core

Opened 9 years ago

Closed 9 years ago

#35678 closed defect (bug) (wontfix)

Avoid using HTML tags in translation strings (wp-admin/update-core.php)

Reported by: ramiy's profile ramiy Owned by:
Milestone: Priority: normal
Severity: normal Version:
Component: I18N Keywords: has-patch
Focuses: Cc:

Description

See the attached patch.

Attachments (3)

35678.patch​ (822 bytes) - added by ramiy 9 years ago.
35678.2.patch​ (947 bytes) - added by ramiy 9 years ago.
35678.3.patch​ (827 bytes) - added by ramiy 9 years ago.

Download all attachments as: .zip

Change History (10)

@ramiy
9 years ago

#1 @ramiy
9 years ago

  • Keywords has-patch added

@ramiy
9 years ago

#2 @ramiy
9 years ago

Old string:

  • <a href="%s">Learn more about WordPress %s</a>.

New strings:

  • %s.
  • Learn more about WordPress %s

#3 @SergeyBiryukov
9 years ago

%s. seems confusing as a translatable string.

#4 @ramiy
9 years ago

I prefer the move the period into the <a> link.

@ramiy
9 years ago

#5 @ramiy
9 years ago

Old string:

  • <a href="%s">Learn more about WordPress %s</a>.

New strings (3rd patch):

  • Learn more about WordPress %s.

This ticket was mentioned in ​Slack in #core-i18n by ocean90. ​View the logs.
9 years ago

#7 @ocean90
9 years ago

  • Milestone Awaiting Review deleted
  • Resolution set to wontfix
  • Status changed from new to closed

Closing as wontfix because the period should stay out of the link. There is also a similar string Welcome to WordPress %1$s. <a href="%2$s">Learn more</a>.

As mentioned on Slack, it's worth to investigate if the string is even displayed and if we can remove it.

Note: See TracTickets for help on using tickets.