Provide an "Edit user" link after adding a new user to a site or network

[jeremyfelt]

In both wp-admin/user-new.php and wp-admin/network/user-new.php, when a new user is added the confirmation message shows only that—"User added."

To aid in workflows attached to creating users, we should provide a link to edit the new user, similar to what we do when creating new sites—"Site added. Visit Dashboard or Edit Site"

In wp-admin/user-new.php, the link should go to wp-admin/user-edit.php.
In wp-admin/network/user-new.php, the link should go to wp-admin/network/user-edit.php.

[ericlewis]

This would be great. Adding good-first-bug since this sounds straight-forward.

[codex-m]

Patch

[codex-m]

Hi @jeremyfelt / @ericlewis I agree this is a user-friendly feature to add. I wrote a patch (35705.diff - attached) for this and thoroughly tested in my local. Works for both network, sub-sites and even single site add user scenarios. It shows a link after adding a new user , allowing to edit the user easily.

See attached sample screenshot.

Thanks :)

[ocean90]

@codex-m: The patch doesn't confirm with our ​coding standards. Can you give it a refresh please?

[jorbin]

The beta 1 deadline for 4.5 is tomorrow, which means no new enhancements can go in after that. Punting from 4.5

[codex-m]

Refreshed version of the patch

[codex-m]

@ocean90 / @jorbin Thanks! I attached a refreshed version of the patch based on latest SVN copy. Please review :)

[jorbin]

@codex-m thanks for refereshing it, but much of @ocean90's statement about coding standards hold true, especially as it relates to ​white space usage.

[codex-m]

Refreshed version with improved white space usage

[codex-m]

Thanks @jorbin Yep my mistake.(first time here) I attached the patch with improve space usage. Cheers.

[codex-m]

Any chance this enhancement will be available in 4.5? We are managing a multi-site with several users added/edited on a daily basis. We find this new feature very useful. Thank you :)

[jeremyfelt]

Taking a look at this now, hopefully before I lose LTE signal. :)

[SergeyBiryukov]

Previously: comment:7:ticket:19470

[jeremyfelt]

35705.2.diff​ continues @codex-m's approach.

The Edit User link works as expected. However, the "Back to Users" link on the Edit User page is now confusing if you land there via Add User instead of the Users list table.

We may be able to just remove the "Back to Users" text if the referer is the Add Users page.

[jeremyfelt]

35705.3.diff​ checks the referrer and only shows "Back to Users" if user-new.php is not part of the string.

[jeremyfelt]

35705.4.diff​ checks for a WP_Error after wpmu_activate_signup and at least doesn't attempt to pass an invalid user ID in the referer. This isn't perfect, but our handling of it currently is not perfect either. We need to take a bigger look at all of this one day.

[jeremyfelt]

In 36695:

Multisite: Provide an "Edit user" link after adding a new user

Props codex-m, jeremyfelt.
Fixes #35705.

[ocean90]

In 36697:

I18N: Fix placeholders and add translator comments after [36695].

See #35705.

[ramiy]

@ocean90 see the attached patch. Simpler strings without placeholders, and without HTML tags in translation strings.

[ocean90]

@ramiy Same story as #35746.