Rename from `term_description` to `get_term_description`

[sebastian.pisula]

I think that name of function suggest that function display value.

[swissspidy]

We can't simply rename a function due to backwards compatibility.

The only option would be a the_term_description() function, although I don't see a need for that.

[sebastian.pisula]

In my patch is in deprecated file:

<?php
function term_description( $term = 0, $taxonomy = 'post_tag' ) { 
        _deprecated_function( __FUNCTION__, '4.5', 'get_term_description()' ); 
                 
        return get_term_description( $term, $taxonomy ); 
} 

[swissspidy]

With that patch we'd end up with two functions that do exactly the same, for no real reason.

One rule of thumb in WordPress core development is: Code refactoring should not be done just because we can.

See ​https://make.wordpress.org/core/2011/03/23/code-refactoring/ for more information.

[SergeyBiryukov]

We could probably add get_the_term_description() as an alias (there was a precedent in [27409]) and the_term_description() as a template tag, although I don't see a need for that either.

See the list of all the_* and get_the_* functions in comment:28:ticket:24164 for reference.

[boonebgorges]

Closing based on the arguments above.