WordPress.org

Make WordPress Core

Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#36249 closed defect (bug) (fixed)

Avoid using HTML tags in translation strings (wp-admin/options-writing.php)

Reported by: ramiy Owned by: SergeyBiryukov
Milestone: 4.6 Priority: normal
Severity: normal Version:
Component: I18N Keywords: has-patch
Focuses: administration Cc:

Description

In the Settings > Writing screen, replace <kbd>%s</kbd>, <kbd>%s</kbd>, <kbd>%s</kbd> with %s in translation string.

Old string:

  • To post to WordPress by email you must set up a secret email account with POP3 access. Any mail received at this address will be posted, so it&#8217;s a good idea to keep this address very secret. Here are three random strings you could use: <kbd>%s</kbd>, <kbd>%s</kbd>, <kbd>%s</kbd>.

New string:

  • To post to WordPress by email you must set up a secret email account with POP3 access. Any mail received at this address will be posted, so it&#8217;s a good idea to keep this address very secret. Here are three random strings you could use: %s.

(See the attached patch)

Attachments (3)

36249.patch (1.2 KB) - added by ramiy 3 years ago.
36249.2.patch (1.3 KB) - added by ramiy 3 years ago.
36249.3.patch (1.3 KB) - added by ramiy 3 years ago.

Download all attachments as: .zip

Change History (10)

@ramiy
3 years ago

@ramiy
3 years ago

#1 @ramiy
3 years ago

  • Keywords has-patch added

The second patch has translators comments.

#2 follow-up: @ocean90
3 years ago

  • Keywords close added; has-patch removed

The comma needs to be translatable, see https://en.wikipedia.org/wiki/Comma#In_other_languages.

@ramiy
3 years ago

#3 in reply to: ↑ 2 @ramiy
3 years ago

Replying to ocean90:

The comma needs to be translatable, see https://en.wikipedia.org/wiki/Comma#In_other_languages.

Done. See the 3rd patch.

Replacing <kbd>%s</kbd>, <kbd>%s</kbd>, <kbd>%s</kbd> with %1$s, %2$s, %3$s

#4 @ramiy
3 years ago

  • Keywords has-patch added; close removed

#5 @ocean90
3 years ago

  • Milestone changed from Awaiting Review to Future Release

Related: #22942

#6 @SergeyBiryukov
3 years ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 37198:

I18N: Remove <kbd> tags from translatable string in wp-admin/options-writing.php.

Add translator comment.

Props ramiy.
Fixes #36249.

#7 @SergeyBiryukov
3 years ago

  • Milestone changed from Future Release to 4.6
Note: See TracTickets for help on using tickets.