Make WordPress Core

Opened 8 years ago

Closed 8 years ago

Last modified 8 years ago

#36555 closed defect (bug) (fixed)

Semantic elements for non-link links: /wp-admin/includes/class-wp-media-list-table.php

Reported by: joedolson's profile joedolson Owned by: joedolson's profile joedolson
Milestone: 4.6 Priority: normal
Severity: normal Version:
Component: Administration Keywords: has-patch commit semantic-buttons
Focuses: accessibility Cc:


Adds aria-button-if-js class to links in the Media list table that behave as buttons. See #26504

Attachments (2)

36555.patch (3.9 KB) - added by joedolson 8 years ago.
Adds aria-button-if-js where appropriate
36555.2.patch (4.3 KB) - added by afercia 8 years ago.

Download all attachments as: .zip

Change History (8)

8 years ago

Adds aria-button-if-js where appropriate

#1 @afercia
8 years ago

  • Milestone changed from Awaiting Review to 4.6
  • Owner set to afercia
  • Status changed from new to assigned

#2 @afercia
8 years ago

  • Owner changed from afercia to joedolson

Thinking maybe some links should be real <button> elements since they're hidden when JS is off. So, they wouldn't need the class aria-button-if-js. Specifically, the ones with the class hide-if-no-js that open the "attach" modal.
About the styling part, there's #35126. Thoughts?

This ticket was mentioned in Slack in #accessibility by afercia. View the logs.

8 years ago

8 years ago

#4 @afercia
8 years ago

  • Keywords commit added

Refreshed patch due to recent changes see [37941].
Also, rebuilt from the root and removes some tab characters in an empty line. Looks good to me, ready for commit consideration.

#5 @ocean90
8 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 38031:

Accessibility: Add aria-button-if-js class to links in the media list table that behave like buttons when JavaScript is on.

Props joedolson, afercia.
See #26504.
Fixes #36555.

#6 @afercia
8 years ago

  • Keywords semantic-buttons added
Note: See TracTickets for help on using tickets.